Skip to content

Commit e05bf53

Browse files
committed
capture httpclient.HTTPError and update timeout value
1 parent 1b620f4 commit e05bf53

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

jupyter_server_proxy/handlers.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import aiohttp
1212
from asyncio import Lock
1313

14-
from tornado import gen, web, httpclient, simple_httpclient, httputil, process, websocket, ioloop, version_info
14+
from tornado import gen, web, httpclient, httputil, process, websocket, ioloop, version_info
1515

1616
from notebook.utils import url_path_join
1717
from notebook.base.handlers import IPythonHandler, utcnow
@@ -216,11 +216,14 @@ async def proxy(self, host, port, proxied_path):
216216

217217
try:
218218
response = await client.fetch(req, raise_error=False)
219-
except simple_httpclient.HTTPTimeoutError as err:
220-
self._record_activity()
221-
self.set_status(408)
222-
self.write(str(err))
223-
return
219+
except httpclient.HTTPError as err:
220+
if err.code == 599:
221+
self._record_activity()
222+
self.set_status(599)
223+
self.write(str(err))
224+
return
225+
else:
226+
raise
224227

225228
# record activity at start and end of requests
226229
self._record_activity()
@@ -316,7 +319,7 @@ def proxy_request_headers(self):
316319
def proxy_request_options(self):
317320
'''A dictionary of options to be used when constructing
318321
a tornado.httpclient.HTTPRequest instance for the proxy request.'''
319-
return dict(follow_redirects=False, request_timeout=75.0)
322+
return dict(follow_redirects=False, connect_timeout=250, request_timeout=300.0)
320323

321324
def check_xsrf_cookie(self):
322325
'''

0 commit comments

Comments
 (0)