Skip to content

Commit 9a1f25e

Browse files
authored
Merge pull request #419 from trungleduc/lab4
Add JupyterLab 4 support for the extension
2 parents 86d21af + 2243acf commit 9a1f25e

File tree

9 files changed

+3692
-3475
lines changed

9 files changed

+3692
-3475
lines changed

.github/workflows/test.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,20 @@ jobs:
3131
matrix:
3232
python-version: ["3.8", "3.11"]
3333
jupyter_server-version: ["1", "2"]
34-
jupyterlab-version: ["3"]
34+
jupyterlab-version: ["3", "4"]
3535
os: [ubuntu-22.04]
3636
include:
3737
- python-version: "3.11"
3838
jupyter_server-version: "2"
3939
jupyterlab-version: "3"
4040
os: windows-2022
41+
- python-version: "3.11"
42+
jupyter_server-version: "2"
43+
jupyterlab-version: "4"
44+
os: windows-2022
45+
exclude:
46+
- jupyter_server-version: "1"
47+
jupyterlab-version: "4"
4148

4249
runs-on: ${{ matrix.os }}
4350
defaults:

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,3 +148,4 @@ dmypy.json
148148

149149
# Cython debug symbols
150150
cython_debug/
151+
labextension/.yarn/

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Welcome! As a [Jupyter](https://jupyter.org) project, we follow the [Jupyter contributor guide](https://jupyter.readthedocs.io/en/latest/contributor/content-contributor.html).
44

5-
To setup a local development environment and ru tests, see the small section in
5+
To setup a local development environment and run tests, see the small section in
66
the README.md file.
77

88
## Local development setup

labextension/.yarnrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# jlpm in JupyterLab 2 and 3 is yarn 1, and this is a yarn 1 compatible
2+
# configuration file.
3+
#
4+
# Config reference: https://classic.yarnpkg.com/lang/en/docs/yarnrc/
5+
#
16
disable-self-update-check true
27
ignore-optional true
38
network-timeout "300000"

labextension/.yarnrc.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# jlpm in JupyterLab 4 is yarn 3, and this is a yarn 2+ compatible configuration
2+
# file.
3+
#
4+
# Config reference: https://yarnpkg.com/configuration/yarnrc
5+
#
6+
nodeLinker: node-modules
7+
httpTimeout: 300000
8+
npmRegistryServer: "https://registry.npmjs.org/"

labextension/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ configured server processes managed by the python package `jupyter-server-proxy`
77

88
## Prerequisites
99

10-
- JupyterLab >=2,<4
10+
- JupyterLab >=2,<5
1111

1212
## Installation
1313

14-
For JupyterLab 3, use your preferred Python package manager to install `jupyter-server-proxy`:
14+
For JupyterLab 3+, use your preferred Python package manager to install `jupyter-server-proxy`:
1515

1616
```bash
1717
pip install jupyter-server-proxy
@@ -40,4 +40,4 @@ jupyter labextension install @jupyterhub/jupyter-server-proxy
4040
> - a download of a great deal of build assets from `npmjs.org`
4141
> - a large `webpack` build that may exhaust memory and open files handles
4242
>
43-
> **Please** consider upgrading to JupyterLab 3 before reporting issues.
43+
> **Please** consider upgrading to JupyterLab 3+ before reporting issues.

labextension/package.json

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,15 @@
4343
"deduplicate": "yarn-deduplicate -s fewer --fail"
4444
},
4545
"dependencies": {
46-
"@jupyterlab/application": "^2.0 || ^3.0",
47-
"@jupyterlab/launcher": "^2.0 || ^3.0"
48-
},
49-
"resolutions": {
50-
"loader-utils": ">=2.0.3"
46+
"@jupyterlab/application": "^2.0 || ^3.0 || ^4.0",
47+
"@jupyterlab/launcher": "^2.0 || ^3.0 || ^4.0"
5148
},
5249
"devDependencies": {
53-
"@jupyterlab/builder": "^3.2.4",
50+
"@jupyterlab/builder": "^3.2.4 || ^4.0.0",
51+
"npm-run-all": "^4.1.5",
5452
"rimraf": "^3.0.2",
5553
"typescript": "~4.8.4",
56-
"yarn-deduplicate": "^6.0.0",
57-
"npm-run-all": "^4.1.5"
54+
"yarn-deduplicate": "^6.0.0"
5855
},
5956
"jupyterlab": {
6057
"extension": true,

0 commit comments

Comments
 (0)