Skip to content

Commit 887c3d1

Browse files
authored
Merge pull request #485 from consideRatio/pr/remove-workaround-for-py312
ci: remove workaround running test in py311 instead of py312
2 parents 337f1f8 + 82e22b1 commit 887c3d1

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

.github/workflows/test.yaml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,18 @@ jobs:
8787
python-version: "3.8"
8888
pip-extras: lab
8989

90-
# FIXME: If https://github.com/jupyter/notebook/pull/7305 gets merged
91-
# and released, we can test "classic" with python 3.12 as well,
92-
# but until then we exclude it from being run as a Python 3.12
93-
# test and include it as a Python 3.11 test.
90+
# pip-extras classic (notebook v6) isn't working with python 3.12 or
91+
# later, so we exclude it here and then include it below to run with
92+
# python 3.11 instead.
9493
- os: ubuntu-22.04
9594
python-version: "3.12"
9695
pip-extras: classic
9796
include:
97+
# Compensates for an excluded test case above
98+
- os: ubuntu-22.04
99+
python-version: "3.11"
100+
pip-extras: classic
101+
98102
# this test is manually updated to reflect the lower bounds of
99103
# versions from dependencies
100104
- os: ubuntu-22.04
@@ -106,11 +110,6 @@ jobs:
106110
tornado==6.1.0
107111
traitlets==5.1.0
108112
109-
# Workaround for excluded 3.12 test mentioned in a FIXME above
110-
- os: ubuntu-22.04
111-
python-version: "3.11"
112-
pip-extras: classic
113-
114113
steps:
115114
- uses: actions/checkout@v4
116115

0 commit comments

Comments
 (0)