Skip to content

Commit 7f5b351

Browse files
committed
more test work
1 parent b7d3378 commit 7f5b351

File tree

4 files changed

+25
-26
lines changed

4 files changed

+25
-26
lines changed

.github/workflows/test.yaml

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ jobs:
5656
path: ./dist
5757

5858
test:
59+
name: |-
60+
${{ matrix.os }}
61+
py${{ matrix.python-version }}
62+
srv${{ matrix.jupyter_server-version }}
63+
lab${{ matrix.jupyterlab-version }}
64+
nb${{ matrix.notebook-version }}
5965
needs: [build]
6066
timeout-minutes: 30
6167
strategy:
@@ -90,7 +96,6 @@ jobs:
9096
shell: bash
9197

9298
steps:
93-
9499
- uses: actions/checkout@v4
95100

96101
- uses: actions/setup-python@v4
@@ -119,20 +124,6 @@ jobs:
119124
pip freeze
120125
pip check
121126
122-
- name: Run tests
123-
run: |
124-
pytest -k "not acceptance" -vv
125-
126-
- name: Upload pytest and coverage reports
127-
if: always()
128-
uses: actions/upload-artifact@v3
129-
with:
130-
name: |-
131-
unit-tests-${{ matrix.python-version }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
132-
path: |
133-
./build/pytest
134-
./build/coverage
135-
136127
- name: Check the Notebook Server extension is installed
137128
if: matrix.jupyterlab-version != '4'
138129
run: |
@@ -150,14 +141,21 @@ jobs:
150141
jupyter labextension list
151142
jupyter labextension list 2>&1 | grep -iE '@jupyterhub/jupyter-server-proxy.*OK.*'
152143
153-
# TODO: re-enable when upstream not broken
154-
# - name: Lab extension browser check
155-
# run: |
156-
# python -m jupyterlab.browser_check
157-
158-
- name: Run acceptance tests
144+
- name: Run tests
159145
run: |
160-
pytest -s -k "acceptance"
146+
mkdir build
147+
cd build
148+
pytest -vv ../tests -c ../pyproject.toml
149+
150+
- name: Upload pytest and coverage reports
151+
if: always()
152+
uses: actions/upload-artifact@v3
153+
with:
154+
name: |-
155+
unit-tests-${{ matrix.python-version }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
156+
path: |
157+
./build/pytest
158+
./build/coverage
161159
162160
- name: Upload acceptance test reports
163161
if: always()

labextension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"watch:src": "jlpm build:lib -w --preserveWatchOutput",
4242
"watch:labextension": "jupyter labextension watch .",
4343
"deduplicate": "yarn-deduplicate -s fewer --fail",
44-
"lint:prettier": "prettier --write --list-different \"../.github/*.yaml\" \"../*.{yaml,yml,md}\" \"../docs/**/*.md\" \"src/**/*.{tsx,ts}\""
44+
"lint:prettier": "prettier --write \"../.github/**/*.yaml\" \"../*.{yaml,yml,md}\" \"../docs/**/*.md\" \"src/**/*.{tsx,ts}\""
4545
},
4646
"dependencies": {
4747
"@jupyterlab/application": "^2.0 || ^3.0 || ^4.0",

tests/acceptance/Notebook.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ https://robotframework-jupyterlibrary.readthedocs.io/en/stable/.
66
Documentation Server Proxies in Notebook
77
Library JupyterLibrary
88
Suite Setup Start Notebook Tests
9-
Test Tags app:nmotebook
9+
Test Tags app:notebook
1010

1111
*** Test Cases ***
1212
Notebook Loads

tests/conftest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ def a_server(
8989

9090

9191
def wait_until_urlopen(url, **kwargs):
92-
retries = 10
92+
retries = 20
93+
9394
while retries:
94-
time.sleep(1)
9595
try:
9696
urlopen(url, **kwargs)
9797
break
@@ -107,6 +107,7 @@ def wait_until_urlopen(url, **kwargs):
107107
flush=True,
108108
)
109109
retries -= 1
110+
time.sleep(0.5)
110111

111112

112113
@fixture

0 commit comments

Comments
 (0)