Merge remote-tracking branch 'origin/gh-370-hatchling' into gh-370-hatchling

bollwyvl · bollwyvl · commit 75e49cd8f248 · 2023-01-11T07:47:45.000-06:00
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -53,7 +53,6 @@ jobs:
 
       - name: Build dist
         run: |
-          set -eux
           pyproject-build
           cd dist && sha256sum * | tee SHA256SUMS
 
@@ -65,7 +64,6 @@ jobs:
 
       - name: Javascript package
         run: |
-          set -eux
           mkdir jsdist
           cd labextension
           jlpm pack --filename ../jsdist/labextension-jlpmpack.tgz
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -39,7 +39,7 @@ To install these in addition to the [Python package](#python-package) test
 dependencies, run:
 
 ```bash
-pip install -e .[acceptance]
+pip install -e ".[acceptance]"
 ```
 
 In addition, compatible versions of:
diff --git a/pyproject.toml b/pyproject.toml
@@ -50,6 +50,7 @@ test = [
     "pytest-cov",
     "pytest-html",
 ]
+# acceptance tests additionally require firefox and geckodriver
 acceptance = [
     "jupyter-server-proxy[test]",
     "notebook <7",

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ test = [`
`50`	`50`	`"pytest-cov",`
`51`	`51`	`"pytest-html",`
`52`	`52`	`]`
	`53`	`+# acceptance tests additionally require firefox and geckodriver`
`53`	`54`	`acceptance = [`
`54`	`55`	`"jupyter-server-proxy[test]",`
`55`	`56`	`"notebook <7",`