Merge pull request #91 from yuvipanda/no-200

Count process as ready if it can respond

Author: ryanlovett

docs/server-process.rst

@@ -41,6 +41,9 @@ pairs.
 
    Timeout in seconds for the process to become ready, default ``5s``.
 
+   A process is considered 'ready' when it can return a valid HTTP response on the
+   port it is supposed to start at.
+
 #. **environment**
 
    One of:

jupyter_server_proxy/handlers.py

@@ -298,8 +298,10 @@ async def _http_ready_func(self, p):
         async with aiohttp.ClientSession() as session:
             try:
                 async with session.get(url) as resp:
+                    # We only care if we get back *any* response, not just 200
+                    # If there's an error response, that can be shown directly to the user
                     self.log.debug('Got code {} back from {}'.format(resp.status, url))
-                    return resp.status == 200
+                    return True
             except aiohttp.ClientConnectionError:
                 self.log.debug('Connection to {} refused'.format(url))
                 return False

setup.py

@@ -3,7 +3,7 @@
 
 setuptools.setup(
     name="jupyter-server-proxy",
-    version='1.0beta7',
+    version='1.0beta8',
     url="https://github.com/jupyterhub/jupyter-server-proxy",
     author="Ryan Lovett & Yuvi Panda",
     author_email="rylo@berkeley.edu",