Skip to content

Commit 6a1370b

Browse files
committed
ci: refactor without changing test matrix
1 parent c1fcdd0 commit 6a1370b

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

.github/workflows/test.yaml

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# This is a GitHub workflow defining a set of jobs with a set of steps.
2-
# ref: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions
2+
# ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions
33
#
44
name: Test
55

@@ -73,26 +73,31 @@ jobs:
7373
strategy:
7474
fail-fast: false
7575
matrix:
76+
os: [ubuntu-22.04]
7677
python-version: ["3.8", "3.11"]
7778
jupyter_server-version: ["1", "2"]
7879
jupyterlab-version: ["3", "4"]
79-
os: [ubuntu-22.04]
8080
include:
81-
- python-version: "3.11"
82-
jupyter_server-version: "2"
81+
# let jupyterlab-version 3 and 4 imply notebook-version 6 and 7
82+
# respectively, to avoid doubling the amount of test runs
83+
- jupyterlab-version: "3"
84+
notebook-version: "6"
85+
- jupyterlab-version: "4"
86+
notebook-version: "7"
87+
# windows should work for all test variations, but a limited selection
88+
# is run to avoid doubling the amount of test runs
89+
- os: windows-2022
90+
python-version: "3.8"
91+
jupyter_server-version: "1"
8392
jupyterlab-version: "3"
8493
notebook-version: "6"
85-
os: windows-2022
86-
- python-version: "3.11"
94+
- os: windows-2022
95+
python-version: "3.11"
8796
jupyter_server-version: "2"
8897
jupyterlab-version: "4"
89-
os: windows-2022
90-
notebook-version: "7"
91-
- jupyterlab-version: "3"
92-
notebook-version: "6"
93-
- jupyterlab-version: "4"
9498
notebook-version: "7"
9599
exclude:
100+
# jupyterlab-version 4 requires jupyter_server-version 2
96101
- jupyter_server-version: "1"
97102
jupyterlab-version: "4"
98103

0 commit comments

Comments
 (0)