Skip to content

Commit 4e36d49

Browse files
authored
Revert addition of set -eux
I think `-e` to error early and `-x` to print statements is the default in a github actions runner already. The addition of `-u` to error on using unset environment variables is the addtion I think isn't a default. If we need a stricter shell script execution, we can use `defaults.run`, see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#defaultsrun.
1 parent 1c58fb8 commit 4e36d49

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

.github/workflows/publish.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ jobs:
5555
5656
- name: Build dist
5757
run: |
58-
set -eux
5958
pyproject-build
6059
cd dist && sha256sum * | tee SHA256SUMS
6160
@@ -67,7 +66,6 @@ jobs:
6766
6867
- name: Javascript package
6968
run: |
70-
set -eux
7169
mkdir jsdist
7270
cd labextension
7371
jlpm pack --filename ../jsdist/labextension-jlpmpack.tgz

.github/workflows/test.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,15 @@ jobs:
7171
#
7272
# Pytest options are set in tests/pytest.ini.
7373
run: |
74-
set -eux
7574
pip install -vv $(ls ./dist/jupyter_server_proxy-*.whl)\[acceptance\] 'jupyterlab~=${{ matrix.jupyterlab-version }}.0'
7675
7776
- name: List Python packages
7877
run: |
79-
set -eux
8078
pip freeze
8179
pip check
8280
8381
- name: Run tests
8482
run: |
85-
set -eux
8683
JUPYTER_TOKEN=secret jupyter-${{ matrix.jupyter-app }} --config=./tests/resources/jupyter_server_config.py &
8784
sleep 5
8885
cd tests
@@ -100,7 +97,6 @@ jobs:
10097
10198
- name: Check the Notebook Server extension is installed
10299
run: |
103-
set -eux
104100
jupyter serverextension list
105101
jupyter serverextension list 2>&1 | grep -iE "jupyter_server_proxy.*OK" -
106102
@@ -114,7 +110,6 @@ jobs:
114110
- name: Install JupyterLab Extension
115111
if: matrix.jupyterlab-version == '2'
116112
run: |
117-
set -eux
118113
export NODE_OPTIONS=--openssl-legacy-provider
119114
cd labextension
120115
jupyter labextension install . --no-build --debug
@@ -128,14 +123,12 @@ jobs:
128123
#
129124
if: ${{ !(matrix.jupyterlab-version == '2' && startsWith(matrix.python-version, '3.11')) }}
130125
run: |
131-
set -eux
132126
jupyter labextension list
133127
jupyter labextension list 2>&1 | grep -iE '@jupyterhub/jupyter-server-proxy.*OK.*'
134128
python -m jupyterlab.browser_check
135129
136130
- name: Run acceptance tests
137131
run: |
138-
set -eux
139132
pytest -s -k "acceptance"
140133
141134
- name: Upload acceptance test reports

0 commit comments

Comments
 (0)