Skip to content

Commit 47fd273

Browse files
committed
Require tornado 5.1 where selected_subprotocol was introduced
1 parent 33a1e6d commit 47fd273

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595
pip-install-constraints: >-
9696
jupyter-server==1.0
9797
simpervisor==1.0
98-
tornado==5.0
98+
tornado==5.1
9999
traitlets==4.2.1
100100
101101
steps:

jupyter_server_proxy/handlers.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -546,10 +546,6 @@ def select_subprotocol(self, subprotocols):
546546
https://github.com/tornadoweb/tornado/blob/v6.4.0/tornado/websocket.py#L337-L360.
547547
"""
548548
if subprotocols:
549-
# Tornado 5.0 doesn't pass an empty list, but a list with a an empty
550-
# string element.
551-
if subprotocols[0] == "":
552-
return None
553549
self.log.debug(
554550
f"Client sent subprotocols: {subprotocols}, selecting the first"
555551
)

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ dependencies = [
5050
"importlib_metadata >=4.8.3 ; python_version<\"3.10\"",
5151
"jupyter-server >=1.0",
5252
"simpervisor >=1.0",
53-
"tornado >=5.0",
53+
"tornado >=5.1",
5454
"traitlets >= 4.2.1",
5555
]
5656

0 commit comments

Comments
 (0)