address comments

Author: ganisback

jupyter_server_proxy/handlers.py

@@ -376,8 +376,8 @@ async def proxy(self, host, port, proxied_path):
         else:
             client = httpclient.AsyncHTTPClient()
         # check if the request is stream request
-        proxy_streaming = self.request.headers.get('Accept')
-        if proxy_streaming == 'text/event-stream':
+        accept_header = self.request.headers.get('Accept')
+        if accept_header == 'text/event-stream':
             return await self._proxy_progressive(host, port, proxied_path, body, client)
         else:
             return await self._proxy_buffered(host, port, proxied_path, body, client)

tests/test_proxies.py

@@ -371,13 +371,10 @@ def streaming_cb(data):
     await client.fetch(
         url,
         headers={"Accept": "text/event-stream"},
-        request_timeout=22,
         streaming_callback=streaming_cb,
     )
     assert times_called == limit
-    print(stream_read_intervals)
     assert all([0.45 < t < 3.0 for t in stream_read_intervals])
-    print(stream_data)
     assert stream_data == [b'data: 0\n\n', b'data: 1\n\n', b'data: 2\n\n']