4545 - uses : actions/setup-node@v4
4646 with :
4747 cache : yarn
48- node-version : 20.x
48+ node-version : " lts/* "
4949 registry-url : https://registry.npmjs.org
5050 cache-dependency-path : labextension/yarn.lock
5151
6868 runs-on : ${{ matrix.os }}
6969 defaults :
7070 run :
71- shell : bash # windows default isn't bash
71+ shell : bash --noprofile --norc -eo pipefail {0} # windows default isn't bash
7272
7373 strategy :
7474 fail-fast : false
@@ -87,14 +87,18 @@ jobs:
8787 python-version : " 3.8"
8888 pip-extras : lab
8989
90- # FIXME: If https://github.com/jupyter/notebook/pull/7305 gets merged
91- # and released, we can test "classic" with python 3.12 as well,
92- # but until then we exclude it from being run as a Python 3.12
93- # test and include it as a Python 3.11 test.
90+ # pip-extras classic (notebook v6) isn't working with python 3.12 or
91+ # later, so we exclude it here and then include it below to run with
92+ # python 3.11 instead.
9493 - os : ubuntu-22.04
9594 python-version : " 3.12"
9695 pip-extras : classic
9796 include :
97+ # Compensates for an excluded test case above
98+ - os : ubuntu-22.04
99+ python-version : " 3.11"
100+ pip-extras : classic
101+
98102 # this test is manually updated to reflect the lower bounds of
99103 # versions from dependencies
100104 - os : ubuntu-22.04
@@ -106,11 +110,6 @@ jobs:
106110 tornado==6.1.0
107111 traitlets==5.1.0
108112
109- # Workaround for excluded 3.12 test mentioned in a FIXME above
110- - os : ubuntu-22.04
111- python-version : " 3.11"
112- pip-extras : classic
113-
114113 steps :
115114 - uses : actions/checkout@v4
116115
@@ -119,7 +118,7 @@ jobs:
119118 python-version : " ${{ matrix.python-version }}"
120119
121120 - name : Update root build packages
122- run : pip install --upgrade pip
121+ run : python -m pip install --upgrade pip
123122
124123 - name : Download built artifacts
125124 uses : actions/download-artifact@v4
0 commit comments