Skip to content

Commit 26b59d8

Browse files
committed
Declare tornado and traitlets as dependencies explicitly
1 parent 0b6669f commit 26b59d8

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

.github/workflows/test.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ jobs:
7676
os: [ubuntu-22.04, windows-2022]
7777
python-version: ["3.8", "3.11"]
7878
pip-extras: ["lab", "classic"]
79+
pip-install-constraints: [""]
7980
exclude:
8081
# windows should work for all test variations, but a limited selection
8182
# is run to avoid doubling the amount of test runs
@@ -86,6 +87,17 @@ jobs:
8687
python-version: "3.8"
8788
pip-extras: lab
8889

90+
# this test is manually updated to reflect the lower bounds of
91+
# versions from dependencies
92+
- os: ubuntu-22.04
93+
python-version: "3.8"
94+
pip-extras: classic
95+
pip-install-constraints: >-
96+
jupyter-server==1.0
97+
simpervisor==1.0
98+
tornado==5.0
99+
traitlets==4.2.1
100+
89101
steps:
90102
- uses: actions/checkout@v4
91103

@@ -108,7 +120,7 @@ jobs:
108120
#
109121
# Pytest options are set in `pyproject.toml`.
110122
run: |
111-
pip install -vv $(ls ./dist/*.whl)\[acceptance,${{ matrix.pip-extras }}\]
123+
pip install -vv $(ls ./dist/*.whl)\[acceptance,${{ matrix.pip-extras }}\] ${{ matrix.pip-install-constraints }}
112124
113125
- name: List Python packages
114126
run: |

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ dependencies = [
5050
"importlib_metadata >=4.8.3 ; python_version<\"3.10\"",
5151
"jupyter-server >=1.0",
5252
"simpervisor >=1.0",
53+
"tornado >=5.0",
54+
"traitlets >= 4.2.1",
5355
]
5456

5557
[project.optional-dependencies]

0 commit comments

Comments
 (0)