Merge pull request #177 from oeway/patch-2

Quote proxied_path to make it a safe URL (fixes #138)

Author: manics

jupyter_server_proxy/handlers.py

@@ -7,7 +7,7 @@
 import inspect
 import socket
 import os
-from urllib.parse import urlunparse, urlparse
+from urllib.parse import urlunparse, urlparse, quote
 import aiohttp
 from asyncio import Lock
 
@@ -141,6 +141,8 @@ def get_client_uri(self, protocol, host, port, proxied_path):
         else:
             client_path = proxied_path
 
+        client_path = quote(client_path)
+
         client_uri = '{protocol}://{host}:{port}{path}'.format(
             protocol=protocol,
             host=host,

tests/test_proxies.py

@@ -2,6 +2,7 @@
 import json
 import os
 from http.client import HTTPConnection
+from urllib.parse import quote
 import pytest
 from tornado.websocket import websocket_connect
 
@@ -19,6 +20,15 @@ def request_get(port, path, token, host='localhost'):
     return h.getresponse()
 
 
+def test_server_proxy_url_encoding():
+    special_path = quote('Hellö Wörld 🎉你好世界@±¥')
+    test_url = '/python-http/' + special_path
+    r = request_get(PORT, test_url, TOKEN)
+    assert r.code == 200
+    s = r.read().decode('ascii')
+    assert s.startswith('GET /{}?token='.format(special_path))
+
+
 def test_server_proxy_non_absolute():
     r = request_get(PORT, '/python-http/abc', TOKEN)
     assert r.code == 200