Skip to content

Commit 8cfc952

Browse files
committed
maint: revert dropping support for py36
For reference note that JupyterHub 3 and 4 requires python 3.7, so batchspawner of a modern version on python 3.6 will probably use JupyterHub 1 or 2.
1 parent 9d9fac2 commit 8cfc952

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/test.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,23 @@ on:
2323
jobs:
2424
pytest:
2525
name: Run pytest
26-
runs-on: ubuntu-22.04
26+
runs-on: ${{ matrix.runs-on || 'ubuntu-22.04' }}
2727

2828
strategy:
2929
fail-fast: false
3030
matrix:
3131
include:
3232
# test oldest supported version
33-
- python-version: "3.7"
33+
- python-version: "3.6"
3434
pip-install-spec: "jupyterhub==1.5.1 sqlalchemy==1.*"
35+
runs-on: ubuntu-20.04 # python 3.6 is only available in 20.04
3536

36-
- python-version: "3.8"
37+
- python-version: "3.7"
3738
pip-install-spec: "jupyterhub==2.* sqlalchemy==1.*"
38-
- python-version: "3.10"
39+
- python-version: "3.8"
3940
pip-install-spec: "jupyterhub==3.*"
41+
- python-version: "3.10"
42+
pip-install-spec: "jupyterhub==4.*"
4043
- python-version: "3.11"
4144
pip-install-spec: "jupyterhub==4.*"
4245

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ profile = "black"
2828
#
2929
[tool.black]
3030
target_version = [
31+
"py36",
3132
"py37",
3233
"py38",
3334
"py39",

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"About Jupyterhub": "http://jupyterhub.readthedocs.io/en/latest/",
3434
"Jupyter Project": "http://jupyter.org",
3535
},
36-
python_requires=">=3.7",
36+
python_requires=">=3.6",
3737
install_require={
3838
"jinja2",
3939
"jupyterhub>=1.5.1",

0 commit comments

Comments
 (0)