Merge pull request #88 from jupytercalpoly/clean

removed unused/redundant code

Author: cameron-toy

.eslintrc.js

@@ -3,7 +3,8 @@ module.exports = {
     'eslint:recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
-    'plugin:prettier/recommended'
+    'plugin:prettier/recommended',
+    'plugin:react/recommended'
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {

census.ipynb

@@ -3071,7 +3071,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.8.3"
+   "version": "3.8.5"
   },
   "presto": {
    "id": "1c9191a6-2e25-4bb0-90f0-68fe8ecbe7f5"

package.json

@@ -52,6 +52,7 @@
     "@lumino/datastore": "^0.10.3",
     "@lumino/dragdrop": "^1.6.2",
     "@lumino/widgets": "^1.13.2",
+    "eslint-plugin-react": "^7.21.1",
     "husky": "^4.2.5",
     "lint-staged": "^10.2.11"
   },

src/button.ts

@@ -20,8 +20,6 @@ import { DocumentRegistry } from '@jupyterlab/docregistry';
 
 import { IChangedArgs } from '@jupyterlab/coreutils';
 
-import { mround } from './utils';
-
 const CANVAS_CLASS = 'pr-Canvas';
 
 const TILED_LAYOUT_CLASS = 'pr-TiledLayout';
@@ -290,10 +288,10 @@ export class DashboardLayout extends Layout {
 
     // Snap to grid if in grid mode.
     if (this._mode === 'grid') {
-      left = mround(left, this._gridSize);
-      top = mround(top, this._gridSize);
-      width = Math.max(mround(width, this._gridSize), this._gridSize);
-      height = Math.max(mround(height, this._gridSize), this._gridSize);
+      left = Private.mround(left, this._gridSize);
+      top = Private.mround(top, this._gridSize);
+      width = Math.max(Private.mround(width, this._gridSize), this._gridSize);
+      height = Math.max(Private.mround(height, this._gridSize), this._gridSize);
       // Change width/height now to force grid changes if they're small.
       item.update(0, 0, 0, 0);
     }
@@ -686,10 +684,10 @@ export class DashboardLayout extends Layout {
     let { left, top, width, height } = pos;
 
     if (this.mode === 'grid') {
-      width = Math.max(mround(width, this._gridSize), this._gridSize);
-      height = Math.max(mround(height, this._gridSize), this._gridSize);
-      left = mround(left, this._gridSize);
-      top = mround(top, this._gridSize);
+      width = Math.max(Private.mround(width, this._gridSize), this._gridSize);
+      height = Math.max(Private.mround(height, this._gridSize), this._gridSize);
+      left = Private.mround(left, this._gridSize);
+      top = Private.mround(top, this._gridSize);
     }
 
     context.strokeRect(left, top, width, height);
@@ -849,3 +847,15 @@ export interface IDashboardChange {
 
   ignore?: boolean;
 }
+
+/**
+ * A namespace for private functionality
+ */
+namespace Private {
+  /**
+   * Rounds num to the nearest integer multiple of roundTo.
+   */
+  export function mround(num: number, roundTo: number): number {
+    return roundTo * Math.round(num / roundTo);
+  }
+}

src/custom_layout.ts

@@ -566,3 +566,32 @@ export namespace DashboardDocumentFactory {
     outputTracker: WidgetTracker<DashboardWidget>;
   }
 }
+
+/**
+ * CURRENTLY UNUSED
+ *
+ * Opens a visual HTMLElement in fullscreen.
+ *
+ * @param node- the element to open in fullscreen.
+ */
+export function openfullscreen(node: HTMLElement): void {
+  // Trigger fullscreen
+  const docElmWithBrowsersFullScreenFunctions = node as HTMLElement & {
+    mozRequestFullScreen(): Promise<void>;
+    webkitRequestFullscreen(): Promise<void>;
+    msRequestFullscreen(): Promise<void>;
+  };
+
+  if (docElmWithBrowsersFullScreenFunctions.requestFullscreen) {
+    docElmWithBrowsersFullScreenFunctions.requestFullscreen();
+  } else if (docElmWithBrowsersFullScreenFunctions.mozRequestFullScreen) {
+    /* Firefox */
+    docElmWithBrowsersFullScreenFunctions.mozRequestFullScreen();
+  } else if (docElmWithBrowsersFullScreenFunctions.webkitRequestFullscreen) {
+    /* Chrome, Safari and Opera */
+    docElmWithBrowsersFullScreenFunctions.webkitRequestFullscreen();
+  } else if (docElmWithBrowsersFullScreenFunctions.msRequestFullscreen) {
+    /* IE/Edge */
+    docElmWithBrowsersFullScreenFunctions.msRequestFullscreen();
+  }
+}