Fix build error

Author: jahn96

src/CodeSnippetEditor.tsx

@@ -448,14 +448,23 @@ export class CodeSnippetEditor extends ReactWidget {
       console.log('modify existing snippet');
       console.log(oldName);
       console.log(newSnippet);
-      this.contentsService
-        .modifyExistingSnippet(oldName, newSnippet)
-        .then((res: boolean) => {
-          if (!res) {
-            console.log('Error in modifying snippet');
-            return false;
+
+      if (oldName.toLowerCase() === newSnippet.name.toLowerCase()) {
+
+        const oldSnippet = this.contentsService.getSnippet(oldName)[0];
+        saveOverWriteFile(this.contentsService, oldSnippet, newSnippet).then((res: boolean) => {
+          if (res) {
+            this.contentsService
+            .modifyExistingSnippet(oldName, newSnippet)
+            .then((res: boolean) => {
+              if (!res) {
+                console.log('Error in modifying snippet');
+                return false;
+              }
+            });
           }
-        });
+        })
+      }
     }
 
     this.saved = true;

src/CodeSnippetInputDialog.ts

@@ -73,16 +73,24 @@ export function CodeSnippetInputDialog(
 
   const body: InputHandler = new InputHandler(tags);
 
-  return showInputDialog(tags, idx, codeSnippetWidget, code, body);
+  return showInputDialog(
+    codeSnippetWidget,
+    tags,
+    idx,
+    codeSnippetManager,
+    code,
+    body
+  );
 }
 
 /**
  * This function creates the actual input form and processes the inputs given.
  */
 export function showInputDialog(
+  codeSnippetWidget: CodeSnippetWidget,
   tags: string[],
   idx: number,
-  codeSnippetWidget: CodeSnippetWidget,
+  codeSnippetManager: CodeSnippetService,
   code: string[],
   body: InputHandler
 ): Promise<Contents.IModel | null> {
@@ -101,7 +109,14 @@ export function showInputDialog(
     console.log(idx);
 
     if (validateForm(result) === false) {
-      showInputDialog(tags, idx, codeSnippetWidget, code, body);
+      showInputDialog(
+        codeSnippetWidget,
+        tags,
+        idx,
+        codeSnippetManager,
+        code,
+        body
+      );
     } else {
       // if (idx === -1) {
       // idx = codeSnippetWidget.codeSnippetWidgetModel.snippets.length;
@@ -116,21 +131,26 @@ export function showInputDialog(
         id: idx,
         tags: tags
       };
-      for (const snippet of snippets) {
+
+      for (const snippet of codeSnippetManager.snippets) {
         if (snippet.name === newSnippet.name) {
-          const result = saveOverWriteFile(
-            codeSnippetManager,
-            snippet,
-            newSnippet
+          saveOverWriteFile(codeSnippetManager, snippet, newSnippet).then(
+            (res: boolean) => {
+              if (res) {
+                codeSnippetWidget.renderCodeSnippetsSignal.emit(
+                  codeSnippetManager.snippets
+                );
+              }
+            }
           );
-          console.log('uh reached here');
-          result
-            .then(newSnippets => {
-              codeSnippetWidget.renderCodeSnippetsSignal.emit(newSnippets);
-            })
-            .catch(_ => {
-              console.log('cancelling overwrite!');
-            });
+          // console.log('uh reached here');
+          // result
+          //   .then(newSnippets => {
+          //     codeSnippetWidget.renderCodeSnippetsSignal.emit(newSnippets);
+          //   })
+          //   .catch(_ => {
+          //     console.log('cancelling overwrite!');
+          //   });
           return;
         }
       }
@@ -183,33 +203,33 @@ function createNewSnippet(
 /**
  * Rename a file, warning for overwriting another.
  */
-async function saveOverWriteFile(
+export async function saveOverWriteFile(
   codeSnippetManager: CodeSnippetService,
   oldSnippet: ICodeSnippet,
   newSnippet: ICodeSnippet
-): Promise<ICodeSnippet[] | null> {
+): Promise<boolean> {
   const newName = newSnippet.name;
 
-  return await shouldOverwrite(newName).then(value => {
-    if (value) {
+  await shouldOverwrite(newName).then(res => {
+    if (res) {
       newSnippet.id = oldSnippet.id;
 
       codeSnippetManager.deleteSnippet(oldSnippet.id).then((res: boolean) => {
         if (!res) {
           console.log('Error in overwriting a snippet (delete)');
-          return;
+          return false;
         }
       });
       codeSnippetManager.addSnippet(newSnippet).then((res: boolean) => {
         if (!res) {
           console.log('Error in overwriting a snippet (add)');
-          return;
+          return false;
         }
       });
-      return codeSnippetManager.snippets;
+      return true;
     }
-    return null;
   });
+  return false;
 }
 
 /**

src/CodeSnippetService.ts

@@ -77,7 +77,9 @@ export class CodeSnippetService {
   }
 
   getSnippet(snippetName: string): ICodeSnippet[] {
-    return this.codeSnippetList.filter(snippet => snippet.name === snippetName);
+    return this.codeSnippetList.filter(
+      snippet => snippet.name.toLowerCase() === snippetName.toLowerCase()
+    );
   }
 
   // isValidSnippet(): boolean {
@@ -177,7 +179,7 @@ export class CodeSnippetService {
   ): Promise<boolean> {
     console.log(this.codeSnippetList);
     for (const snippet of this.codeSnippetList) {
-      if (snippet.name === oldName) {
+      if (snippet.name.toLowerCase() === oldName.toLowerCase()) {
         this.codeSnippetList.splice(snippet.id, 1, newSnippet);
         break;
       }