Skip to content

Commit 888a234

Browse files
committed
Remove console log
1 parent eeb6a96 commit 888a234

File tree

3 files changed

+3
-44
lines changed

3 files changed

+3
-44
lines changed

src/CodeSnippetService.ts

Lines changed: 3 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ export class CodeSnippetService {
3434
this.settingManager.get('snippets').user as JSONArray
3535
);
3636

37-
console.log(userSnippets.length);
3837
if (userSnippets.length !== 0) {
3938
this.codeSnippetList = userSnippets;
4039
} else {
@@ -46,8 +45,6 @@ export class CodeSnippetService {
4645
'snippets',
4746
(this.codeSnippetList as unknown) as PartialJSONValue
4847
);
49-
50-
console.log(this.codeSnippetList);
5148
}
5249

5350
private convertToICodeSnippetList(snippets: JSONArray): ICodeSnippet[] {
@@ -66,7 +63,6 @@ export class CodeSnippetService {
6663
}
6764

6865
static getCodeSnippetService(): CodeSnippetService {
69-
console.log(this.codeSnippetService);
7066
return this.codeSnippetService;
7167
}
7268

@@ -80,19 +76,10 @@ export class CodeSnippetService {
8076
);
8177
}
8278

83-
// isValidSnippet(): boolean {
84-
// // check duplicate name
85-
// // check required fields
86-
87-
// }
88-
8979
async addSnippet(snippet: ICodeSnippet): Promise<boolean> {
9080
const id = snippet.id;
91-
console.log(id);
9281
this.codeSnippetList.splice(id, 0, snippet);
9382

94-
console.log(this.codeSnippetList);
95-
9683
const numSnippets = this.codeSnippetList.length;
9784

9885
// update id's of snippets.
@@ -101,9 +88,6 @@ export class CodeSnippetService {
10188
this.codeSnippetList[i].id += 1;
10289
}
10390

104-
console.log(this.codeSnippetList);
105-
106-
console.log(this.codeSnippetList);
10791
await this.settingManager
10892
.set('snippets', (this.codeSnippetList as unknown) as PartialJSONValue)
10993
.catch((_) => {
@@ -142,13 +126,6 @@ export class CodeSnippetService {
142126
}
143127

144128
async renameSnippet(oldName: string, newName: string): Promise<boolean> {
145-
console.log('renaming');
146-
try {
147-
this.duplicateNameExists(newName);
148-
} catch (e) {
149-
return false;
150-
}
151-
152129
for (const snippet of this.codeSnippetList) {
153130
if (snippet.name === oldName) {
154131
snippet.name = newName;
@@ -163,28 +140,26 @@ export class CodeSnippetService {
163140
return true;
164141
}
165142

166-
duplicateNameExists(newName: string): void {
143+
duplicateNameExists(newName: string): boolean {
167144
for (const snippet of this.codeSnippetList) {
168145
if (snippet.name.toLowerCase() === newName.toLowerCase()) {
169-
throw Error('Duplicate Name of Code Snippet');
146+
return true;
170147
}
171148
}
149+
return false;
172150
}
173151

174152
async modifyExistingSnippet(
175153
oldName: string,
176154
newSnippet: ICodeSnippet
177155
): Promise<boolean> {
178-
console.log(this.codeSnippetList);
179156
for (const snippet of this.codeSnippetList) {
180157
if (snippet.name.toLowerCase() === oldName.toLowerCase()) {
181158
this.codeSnippetList.splice(snippet.id, 1, newSnippet);
182159
break;
183160
}
184161
}
185162

186-
console.log(this.codeSnippetList);
187-
188163
await this.settingManager
189164
.set('snippets', (this.codeSnippetList as unknown) as PartialJSONValue)
190165
.catch((_) => {
@@ -194,8 +169,6 @@ export class CodeSnippetService {
194169
}
195170

196171
async moveSnippet(fromIdx: number, toIdx: number): Promise<boolean> {
197-
console.log(fromIdx);
198-
console.log(toIdx);
199172
if (toIdx > fromIdx) {
200173
toIdx = toIdx - 1;
201174
}

src/CodeSnippetWidget.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,17 +84,11 @@ export class CodeSnippetWidget extends ReactWidget {
8484
}
8585

8686
updateCodeSnippetWidget(): void {
87-
console.log('updating code snippets');
8887
const newSnippets = this.codeSnippetManager.snippets;
89-
console.log(newSnippets);
90-
console.log(this instanceof CodeSnippetWidget);
91-
console.log(this);
92-
console.log(this.renderCodeSnippetsSignal);
9388
this.renderCodeSnippetsSignal.emit(newSnippets);
9489
}
9590

9691
onAfterShow(msg: Message): void {
97-
console.log('onAfterShow');
9892
this.updateCodeSnippetWidget();
9993
}
10094

@@ -320,7 +314,6 @@ export class CodeSnippetWidget extends ReactWidget {
320314

321315
// move code snippet within code snippet explorer
322316
private moveCodeSnippet(srcIdx: number, targetIdx: number): void {
323-
console.log('move snippet');
324317
this.codeSnippetManager
325318
.moveSnippet(srcIdx, targetIdx)
326319
.then((res: boolean) => {

src/index.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -257,14 +257,7 @@ const codeSnippetExtensionSetting: JupyterFrontEndPlugin<void> = {
257257
.load(CODE_SNIPPET_SETTING_ID)
258258
.then((settings) => {
259259
CodeSnippetService.init(settings as Settings);
260-
261260
console.log('JupyterLab extension code-snippets setting is activated!');
262-
263-
// Remove below after testing
264-
const codeSnippetService = CodeSnippetService.getCodeSnippetService();
265-
console.log(codeSnippetService);
266-
267-
// console.log(code)
268261
})
269262
.catch((e) => console.log(e));
270263
},

0 commit comments

Comments
 (0)