Skip to content

Commit 33c8c83

Browse files
committed
Fix ordering issue of snippets after deleting while filtering or searching
1 parent 32d0f35 commit 33c8c83

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

src/CodeSnippetDisplay.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1166,9 +1166,13 @@ export class CodeSnippetDisplay extends React.Component<
11661166
editor.dispose();
11671167
}
11681168

1169+
console.log('delete snippet');
1170+
console.log(codeSnippet.id);
1171+
console.log(this.props._codeSnippetWidgetModel._snippets);
11691172
// deleting snippets when there is one snippet active
11701173
contentsService.delete('snippets/' + codeSnippet.name + '.json');
11711174
this.props._codeSnippetWidgetModel.deleteSnippet(codeSnippet.id);
1175+
this.props._codeSnippetWidgetModel.reorderSnippet();
11721176
this.props._codeSnippetWidgetModel.updateSnippetContents();
11731177

11741178
// active tags after delete

src/CodeSnippetWidget.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,7 @@ export class CodeSnippetWidget extends ReactWidget {
331331
idx = parseInt(snippet.id);
332332
}
333333

334+
console.log(this._codeSnippetWidgetModel.snippets);
334335
/**
335336
* moving snippets inside the snippet panel
336337
*/

src/CodeSnippetWidgetModel.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ export class CodeSnippetWidgetModel implements ICodeSnippetWidgetModel {
2626
this._snippets = snippetList;
2727
}
2828

29+
reorderSnippet(): void {
30+
this.sortSnippets();
31+
for (let i = 0; i < this._snippets.length; i++) {
32+
this._snippets[i].id = i;
33+
}
34+
}
35+
2936
addSnippet(newSnippet: ICodeSnippet, index: number): void {
3037
// append a new snippet created from input form to the end
3138
if (newSnippet.id === -1) {

0 commit comments

Comments
 (0)