Fix karma

Author: fcollonval

.github/workflows/build.yml

@@ -58,9 +58,8 @@ jobs:
         python -m pip install --upgrade -v -e ".[test, examples, docs]"
         yarn run lint:check
 
-        # TODO: re-enable tests
-        # pytest
-        # npm run test:ci
+        pytest
+        npm run test:ci
 
     # - name: Check docs can be build + links
     #   run: |

{{cookiecutter.github_project_name}}/docs/source/conf.py

@@ -29,7 +29,7 @@
     'sphinx.ext.napoleon',
     'sphinx.ext.todo',
     'nbsphinx',
-    'jupyter_sphinx.execute',
+    'jupyter_sphinx',
     'nbsphinx_link',
 ]
 

{{cookiecutter.github_project_name}}/package.json

@@ -43,6 +43,7 @@
     "lint:check": "eslint . --ext .ts,.tsx",
     "prepack": "yarn run build:lib",
     "test": "yarn run test:firefox",
+    "test:ci": "karma start --browsers=ChromeCI tests/karma.conf.js",
     "test:chrome": "karma start --browsers=Chrome tests/karma.conf.js",
     "test:debug": "karma start --browsers=Chrome --singleRun=false --debug=true tests/karma.conf.js",
     "test:firefox": "karma start --browsers=Firefox tests/karma.conf.js",
@@ -59,8 +60,8 @@
     "@phosphor/application": "^1.6.0",
     "@phosphor/widgets": "^1.6.0",
     "@types/expect.js": "^0.3.29",
-    "@types/mocha": "^5.2.5",
-    "@types/node": "^10.11.6",
+    "@types/mocha": "^8.2.0",
+    "@types/node": "^14.14.13",
     "@types/webpack-env": "^1.13.6",
     "@typescript-eslint/eslint-plugin": "^3.6.0",
     "@typescript-eslint/parser": "^3.6.0",
@@ -71,25 +72,25 @@
     "eslint-plugin-prettier": "^3.1.4",
     "expect.js": "^0.3.1",
     "fs-extra": "^7.0.0",
-    "karma": "^3.1.0",
-    "karma-chrome-launcher": "^2.2.0",
-    "karma-firefox-launcher": "^1.1.0",
-    "karma-ie-launcher": "^1.0.0",
-    "karma-mocha": "^1.3.0",
+    "karma": "^5.2.3",
+    "karma-chrome-launcher": "^3.1.0",
+    "karma-coverage": "^2.0.1",
+    "karma-firefox-launcher": "^2.1.0",
+    "karma-mocha": "^2.0.1",
     "karma-mocha-reporter": "^2.2.5",
-    "karma-typescript": "^5.0.3",
-    "karma-typescript-es6-transform": "^5.0.3",
+    "karma-typescript": "^5.2.0",
+    "karma-typescript-es6-transform": "^5.2.0",
     "mkdirp": "^0.5.1",
-    "mocha": "^5.2.0",
+    "mocha": "^8.2.1",
     "npm-run-all": "^4.1.3",
     "prettier": "^2.0.5",
     "rimraf": "^2.6.2",
-    "source-map-loader": "^0.2.4",
+    "source-map-loader": "^1.1.3",
     "style-loader": "^1.0.0",
-    "ts-loader": "^5.2.1",
+    "ts-loader": "^8.0.0",
     "typescript": "~4.1.3",
-    "webpack": "^5",
-    "webpack-cli": "^4"
+    "webpack": "^5.0.0",
+    "webpack-cli": "^4.0.0"
   },
   "jupyterlab": {
     "extension": "lib/plugin",

{{cookiecutter.github_project_name}}/setup.py

@@ -105,7 +105,7 @@
             'sphinx>=1.5',
             'recommonmark',
             'sphinx_rtd_theme',
-            'nbsphinx>=0.2.13,<0.4.0',
+            'nbsphinx',
             'jupyter_sphinx',
             'nbsphinx-link',
             'pytest_check_links',

{{cookiecutter.github_project_name}}/src/version.ts

@@ -1,6 +1,8 @@
 // Copyright (c) {{ cookiecutter.author_name }}
 // Distributed under the terms of the Modified BSD License.
 
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+// @ts-ignore
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const data = require('../package.json');
 

{{cookiecutter.github_project_name}}/tests/karma.conf.js

@@ -25,9 +25,18 @@ module.exports = function (config) {
     singleRun: true,
     logLevel: config.LOG_INFO,
 
+    customLaunchers: {
+      ChromeCI: {
+        base: 'ChromeHeadless',
+        flags: ['--no-sandbox']
+      }
+    },
 
     karmaTypescriptConfig: {
       tsconfig: 'tests/tsconfig.json',
+      coverageOptions: {
+        instrumentation: false
+      },
       reports: {
         "text-summary": "",
         "html": "coverage",
@@ -37,8 +46,20 @@ module.exports = function (config) {
         }
       },
       bundlerOptions: {
+        sourceMap: false,  // Disabled due to error/bug
+        acornOptions: {
+          ecmaVersion: 8,
+        },
         transforms: [
-            require("karma-typescript-es6-transform")()
+          require("karma-typescript-es6-transform")({
+            presets: [
+              ["@babel/preset-env", {
+                targets: {
+                  browsers: ["last 2 Chrome versions"]
+                },
+              }]
+            ]
+          })
         ]
       }
     }

{{cookiecutter.github_project_name}}/tests/src/utils.spec.ts

@@ -3,7 +3,6 @@
 
 import * as widgets from '@jupyter-widgets/base';
 import * as services from '@jupyterlab/services';
-import * as Backbone from 'backbone';
 
 let numComms = 0;
 
@@ -53,7 +52,7 @@ class DummyManager extends widgets.ManagerBase<HTMLElement> {
         this.el = window.document.createElement('div');
     }
 
-    display_view(msg: services.KernelMessage.IMessage, view: Backbone.View<Backbone.Model>, options: any) {
+    display_view(msg: services.KernelMessage.IMessage, view: widgets.DOMWidgetView, options: any) {
         // TODO: make this a spy
         // TODO: return an html element
         return Promise.resolve(view).then(view => {

{{cookiecutter.github_project_name}}/tests/tsconfig.json

@@ -2,15 +2,19 @@
   "compilerOptions": {
     "declaration": true,
     "noImplicitAny": true,
-    "lib": ["dom", "es5", "es2015.promise", "es2015.iterable"],
-    "noEmitOnError": true,
+    "lib": ["dom", "es6"],
+    "noEmitOnError": false,
     "strictNullChecks": true,
     "module": "commonjs",
     "moduleResolution": "node",
-    "target": "ES5",
+    "target": "ES6",
     "outDir": "build",
+    "rootDir": "src",
     "skipLibCheck": true,
-    "sourceMap": true
+    "sourceMap": true,
+    "types": [
+      "mocha"
+    ]
   },
   "include": [
     "src/*.ts",