Convert hyphens to underscore for Python package name (#71)

* convert hyphens to underscore for python

* add hyphen to dash conversion to test

* force test to determine the python package name

in order to test if the hyphens are being replaced correctly

* rename test package everywhere

Author: ianhi

.travis.yml

@@ -33,11 +33,11 @@ script:
   - make linkcheck
   - popd
   # Make a non-local install so the data_files get populated
-  - pip uninstall -y ipywidgettestwidgets
+  - pip uninstall -y jupyter_widget_testwidgets
   - pip install .
-  - jupyter nbextension enable --py --sys-prefix ipywidgettestwidgets
+  - jupyter nbextension enable --py --sys-prefix jupyter_widget_testwidgets
   # Validate nbextension (enable does not use exit code):
-  - python -c "from notebook.nbextensions import validate_nbextension; import sys; sys.exit(validate_nbextension('ipywidgettestwidgets/extension') or 0)"
+  - python -c "from notebook.nbextensions import validate_nbextension; import sys; sys.exit(validate_nbextension('jupyter_widget_testwidgets/extension') or 0)"
   - pip install jupyterlab
   # Make sure our lab extension was installed.
   - jupyter labextension list

cookiecutter.json

@@ -3,7 +3,7 @@
 	"author_email": "",
 	"github_project_name": "",
 	"github_organization_name": "",
-	"python_package_name": "{{ cookiecutter.github_project_name }}",
+	"python_package_name": "{{ cookiecutter.github_project_name | replace('-', '_') }}",
 	"npm_package_name": "{{ cookiecutter.github_project_name }}",
     "npm_package_version": "0.1.0",
 	"project_short_description": "A Custom Jupyter Widget Library"

tests/test_instantiate.py

@@ -29,7 +29,7 @@ def example_instance(tmpdir_factory):
                 yield instance_path
             finally:
                 try:
-                    pip.main(['uninstall', 'ipywidgettestwidgets', '-y'])
+                    pip.main(['uninstall', 'jupyter_widget_testwidgets', '-y'])
                 except Exception:
                     pass
 

tests/testconfig.yaml

@@ -3,7 +3,6 @@ default_context:
     author_email: "testwidget@example.com"
     github_project_name: "jupyter-widget-testwidgets"
     github_organization_name: "jupyter"
-    python_package_name: "ipywidgettestwidgets"
     npm_package_name: "@jupyter-widgets/jupyter-widget-testwidgets"
     npm_package_version: "1.1.0"
     project_short_description: "A Test Jupyter Widget Library"