Skip to content

Commit 188abff

Browse files
authored
Phosphor widget backward compatibility fix on WidgetRenderer (#3933)
1 parent 72b9397 commit 188abff

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/base/src/widget.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -983,6 +983,11 @@ export class JupyterLuminoPanelWidget extends Panel {
983983
private _view: DOMWidgetView;
984984
}
985985

986+
/**
987+
* @deprecated Use {@link JupyterLuminoPanelWidget} instead (Since 8.0).
988+
*/
989+
export const JupyterPhosphorPanelWidget = JupyterLuminoPanelWidget;
990+
986991
export class DOMWidgetView extends WidgetView {
987992
/**
988993
* Public constructor

python/jupyterlab_widgets/src/renderer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ export class WidgetRenderer
7474

7575
let widget: LuminoWidget;
7676
try {
77-
widget = (await manager.create_view(wModel)).luminoWidget;
77+
const view = await manager.create_view(wModel);
78+
widget = view.luminoWidget || view.pWidget;
7879
} catch (err) {
7980
this.node.textContent = 'Error displaying widget';
8081
this.addClass('jupyter-widgets');

0 commit comments

Comments
 (0)