Change add_layer/remove_layer and add_control/remove_control into add… (#982)

* Change add_layer/remove_layer and add_control/remove_control into add/remove working for both layers and controls, in Map Class.

* Update documentation and notebooks replacing add_layer and add_control by add (resp. remove). Add a warning and remove filter.

* Update notebooks from ui-tests/notebooks, replacingadd_layer/control by add.

* Simplify add_layer, remove_layer, substitute layer in Map by using add, clear and substitute and fix flake8 issue.

* Indicate in the docstrings the methods that will be deprecated.

* Take review comments into account : in LayerGroup update add_layer/remover layer.

* Take review comments into account: Update substitute_layer in Layersgroup.

* Fix flake8 issue.

Author: HaudinFlorence

docs/source/controls/draw_control.rst

@@ -48,7 +48,7 @@ Example
         }
     }
 
-    m.add_control(draw_control)
+    m.add(draw_control)
 
     m
 

docs/source/controls/fullscreen_control.rst

@@ -9,7 +9,7 @@ Example
     from ipyleaflet import Map, FullScreenControl
 
     m = Map(zoom=5, center=[51.64, -76.52])
-    m.add_control(FullScreenControl())
+    m.add(FullScreenControl())
 
     m
 

docs/source/controls/layers_control.rst

@@ -21,12 +21,12 @@ Example
     marker1 = Marker(name='marker1', location=(48, -2))
     marker2 = Marker(name='marker2', location=(50, 0))
     marker3 = Marker(name='marker3', location=(52, 2))
-    m.add_layer(marker1)
-    m.add_layer(marker2)
-    m.add_layer(marker3)
+    m.add(marker1)
+    m.add(marker2)
+    m.add(marker3)
 
     control = LayersControl(position='topright')
-    m.add_control(control)
+    m.add(control)
 
     m
 

docs/source/controls/legend_control.rst

@@ -11,7 +11,7 @@ Example
     m = Map(center=(-10,-45), zoom=4)
 
     legend = LegendControl({"low":"#FAA", "medium":"#A55", "High":"#500"}, name="Legend", position="bottomright")
-    m.add_control(legend)
+    m.add(legend)
 
     m
 

docs/source/controls/measure_control.rst

@@ -15,7 +15,7 @@ Example
         active_color = 'orange',
         primary_length_unit = 'kilometers'
     )
-    m.add_control(measure)
+    m.add(measure)
 
     measure.completed_color = 'red'
 

docs/source/controls/scale_control.rst

@@ -9,7 +9,7 @@ Example
     from ipyleaflet import Map, ScaleControl
 
     m = Map(zoom=5, center=[51.64, -76.52])
-    m.add_control(ScaleControl(position='bottomleft'))
+    m.add(ScaleControl(position='bottomleft'))
 
     m
 

docs/source/controls/search_control.rst

@@ -12,7 +12,7 @@ Example
 
     marker = Marker(icon=AwesomeIcon(name="check", marker_color='green', icon_color='darkgreen'))
 
-    m.add_control(SearchControl(
+    m.add(SearchControl(
       position="topleft",
       url='https://nominatim.openstreetmap.org/search?format=json&q={s}',
       zoom=5,
@@ -32,7 +32,7 @@ You can add a callback that will be run when on search found:
         url='https://cartoradon.irsn.fr/commune.py/communes/search/FR/{s}?',
         zoom=5
     )
-    m.add_control(search)
+    m.add(search)
 
     def on_found(**kwargs):
         # Print the result of the search (text, location etc)
@@ -68,7 +68,7 @@ You can also search features from GeoJSON layers.
     layer_group = LayerGroup(layers=(countries,))
     marker = Marker(icon=AwesomeIcon(name="check", marker_color='green', icon_color='darkred'))
 
-    m.add_control(SearchControl(
+    m.add(SearchControl(
       position="topleft",
       layer=layer_group,
       zoom=4,

docs/source/controls/split_map_control.rst

@@ -14,7 +14,7 @@ Example
     left_layer = basemap_to_tiles(basemaps.NASAGIBS.ModisAquaBands721CR, "2017-11-11")
 
     control = SplitMapControl(left_layer=left_layer, right_layer=right_layer)
-    m.add_control(control)
+    m.add(control)
 
     m
 

docs/source/controls/widget_control.rst

@@ -13,11 +13,11 @@ Example
     zoom_slider = IntSlider(description='Zoom level:', min=0, max=15, value=7)
     jslink((zoom_slider, 'value'), (m, 'zoom'))
     widget_control1 = WidgetControl(widget=zoom_slider, position='topright')
-    m.add_control(widget_control1)
+    m.add(widget_control1)
 
     color_picker = ColorPicker(description='Pick a color:')
     widget_control2 = WidgetControl(widget=color_picker, position='bottomright')
-    m.add_control(widget_control2)
+    m.add(widget_control2)
     m
 
 

docs/source/controls/zoom_control.rst

@@ -9,7 +9,7 @@ Example
     from ipyleaflet import Map, ZoomControl
 
     m = Map(zoom=5, center=[51.64, -76.52], zoom_control=False)  # Do not automatically create a ZoomControl
-    m.add_control(ZoomControl(position='topright'))
+    m.add(ZoomControl(position='topright'))
 
     m