Skip to content

Commit 9289ae7

Browse files
authored
set default file ID manager to arbitrary (#37)
1 parent 42f966e commit 9289ae7

File tree

1 file changed

+3
-23
lines changed

1 file changed

+3
-23
lines changed

jupyter_server_fileid/extension.py

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,8 @@
11
from jupyter_events.logger import EventLogger
22
from jupyter_server.extension.application import ExtensionApp
3-
from jupyter_server.services.contents.filemanager import FileContentsManager
43
from traitlets import Type
54

6-
from jupyter_server_fileid.manager import (
7-
ArbitraryFileIdManager,
8-
BaseFileIdManager,
9-
LocalFileIdManager,
10-
)
5+
from jupyter_server_fileid.manager import ArbitraryFileIdManager, BaseFileIdManager
116

127

138
class FileIdExtension(ExtensionApp):
@@ -18,28 +13,13 @@ class FileIdExtension(ExtensionApp):
1813
klass=BaseFileIdManager,
1914
help="""File ID manager instance to use.
2015
21-
Defaults to:
22-
- LocalFileIdManager if contents manager is a FileContentsManager,
23-
- ArbitraryFileIdManager otherwise.
16+
Defaults to ArbitraryFileIdManager.
2417
""",
2518
config=True,
26-
default_value=None,
27-
allow_none=True,
19+
default_value=ArbitraryFileIdManager,
2820
)
2921

3022
def initialize_settings(self):
31-
if self.file_id_manager_class is None:
32-
if isinstance(self.settings["contents_manager"], FileContentsManager):
33-
self.log.info(
34-
"Contents manager is a FileContentsManager. Defaulting to LocalFileIdManager."
35-
)
36-
self.file_id_manager_class = LocalFileIdManager
37-
else:
38-
self.log.info(
39-
"Contents manager is not a FileContentsManager. Defaulting to ArbitraryFileIdManager."
40-
)
41-
self.file_id_manager_class = ArbitraryFileIdManager
42-
4323
self.log.info(f"Configured File ID manager: {self.file_id_manager_class.__name__}")
4424
file_id_manager = self.file_id_manager_class(
4525
log=self.log, root_dir=self.serverapp.root_dir, config=self.config

0 commit comments

Comments
 (0)