Merge pull request #778 from jupyter-lsp/settings-ui

Implement settings UI using native JupyterLab 3.3 UI

Author: krassowski

.github/workflows/job.test.yml

@@ -44,7 +44,7 @@ jobs:
       matrix:
         os: [ubuntu]
         nodejs: ['>=14,<15.0.0a0']
-        lab: ['>=3.1.0,<4.0.0a0']
+        lab: ['>=3.3.0,<4.0.0a0']
         r: ['>=4']
     steps:
       - uses: actions/checkout@v2
@@ -231,12 +231,12 @@ jobs:
             # Node 14 end-of-life: April 2023
             nodejs: '>=14,<15.0.0.a0'
             r: '<4'
-            lab: '>=3.1.0,<3.2'
+            lab: '>=3.3.0,<3.4'
           - python: '3.10'
             # Node 16 end-of-life: April 2024
             nodejs: '>=16,<17.0.0.a0'
             r: '>=4'
-            lab: '>=3.2.0,<4'
+            lab: '>=3.4.0,<4'
 
     steps:
       - uses: actions/checkout@v2
@@ -374,19 +374,19 @@ jobs:
         include:
           - python: '3.7'
             dist: 'jupyter*lsp*.tar.gz'
-            lab: '>=3.1,<3.2'
+            lab: '>=3.3,<3.4'
           - python: '3.8'
             dist: 'jupyter*lsp*.whl'
-            lab: '>=3.1,<3.2'
+            lab: '>=3.3,<3.4'
           - python: '3.9'
             dist: 'jupyter*lsp*.tar.gz'
-            lab: '>=3.2,<3.3'
+            lab: '>=3.4,<4'
           - python: '3.10'
             dist: 'jupyter*lsp*.whl'
-            lab: '>=3.2,<4'
+            lab: '>=3.4,<4'
           - python: 'pypy-3.7'
             dist: 'jupyter*lsp*.tar.gz'
-            lab: '>=3.2,<3.3'
+            lab: '>=3.4,<4'
           - os: 'windows'
             py_cmd: python
           - os: 'macos'
@@ -432,9 +432,9 @@ jobs:
         nodejs: ['14']
         include:
           - python: '3.7'
-            lab: '>=3.1,<3.2'
+            lab: '>=3.3,<3.4'
           - python: '3.10'
-            lab: '>=3.2,<4'
+            lab: '>=3.3,<4'
     steps:
       - name: Install Python
         uses: actions/setup-python@v2

CHANGELOG.md

@@ -1,5 +1,32 @@
 ## Changelog
 
+### `@krassowski/jupyterlab-lsp 4.0.0` (not-yet-released)
+
+- features:
+  - implement jump target selector and jump to references ([#739])
+  - implement settings UI using native JupyterLab 3.3 UI ([#778])
+- bug fixes
+  - use correct websocket URL if configured as different from base URL ([#820], thanks @MikeSem)
+- refactoring:
+  - move client capabilities to features ([#738])
+- documentation:
+  - add missing `--channel` to conda instruction for texlab ([#789], thanks @justin-f-perez)
+  - remove references to pylsp fork ([#800] and [#814], thanks @joelostblom and @nickfong)
+  - add Robot Framework language server ([#724], thanks @bollwyvl)
+  - add a list of third-party and community language servers ([#826], thanks @cccs-jc)
+- maintenance:
+  - bump minimum required JupyterLab version to 3.3 (`>=3.3.0,<4.0.0a0`)
+  - bump minimum required Node.js version to 14.0 (12.0 reached EOL in April)
+
+[#724]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/724
+[#738]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/738
+[#778]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/778
+[#789]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/789
+[#800]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/800
+[#814]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/814
+[#820]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/820
+[#826]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/826
+
 ### `@krassowski/jupyterlab-lsp 3.10.1` (2022-03-21)
 
 - bug fixes:

CONTRIBUTING.md

@@ -35,7 +35,7 @@ Development requires, at a minimum:
 - `python >=3.7,<3.11.0a0`
   - Python 3.7 and 3.10 are fully tested on CI
   - Python 3.7 to 3.10 and PyPy 3 are verified to at least install and import
-- `jupyterlab >=3.1.0,<4.0.0a0`
+- `jupyterlab >=3.3.0,<4.0.0a0`
 
 It is recommended to use a virtual environment (e.g. `virtualenv` or `conda env`)
 for development.

README.md

@@ -90,7 +90,7 @@ Use context menu on rows in the panel to filter out diagnostics or copy their me
 
 You will need to have both of the following installed:
 
-- JupyterLab >=3.1.0,<4.0.0a0
+- JupyterLab >=3.3.0,<4.0.0a0
 - Python 3.7+
 
 In addition, if you wish to use javascript, html, markdown or any other NodeJS-based language server you will need to have appropriate NodeJS version installed.

atest/05_Features/Completion.robot

@@ -11,7 +11,6 @@ Force Tags          feature:completion
 *** Variables ***
 ${COMPLETER_BOX}            css:.jp-Completer.jp-HoverBox
 ${DOCUMENTATION_PANEL}      css:.jp-Completer-docpanel
-${KERNEL_BUSY_INDCA_OLD}    css:.jp-NotebookPanel-toolbar div[title="Kernel Busy"]
 ${KERNEL_BUSY_INDICATOR}    css:.jp-Notebook-ExecutionIndicator[data-status="busy"]
 
 
@@ -452,20 +451,12 @@ Should Complete While Kernel Is Busy
     # Lab Command    Run Selected Cells And Don't Advance
     Press Keys    None    CTRL+ENTER
     # Confirm that the kernel is busy
-    IF    '${LAB VERSION}'.startswith('3.4')
-        Wait Until Page Contains Element    ${KERNEL_BUSY_INDICATOR}    timeout=5s
-    ELSE
-        Wait Until Page Contains Element    ${KERNEL_BUSY_INDCA_OLD}    timeout=5s
-    END
+    Wait Until Page Contains Element    ${KERNEL_BUSY_INDICATOR}    timeout=5s
     # Enter a cell with "t"
     Enter Cell Editor    18
     # Check if completion worked
     Enter Cell Editor    1    line=2
     Trigger Completer    timeout=10s
     Completer Should Suggest    test
     # Confirm that the kernel indicator was busy all along
-    IF    '${LAB VERSION}'.startswith('3.4')
-        Page Should Contain Element    ${KERNEL_BUSY_INDICATOR}
-    ELSE
-        Page Should Contain Element    ${KERNEL_BUSY_INDCA_OLD}
-    END
+    Page Should Contain Element    ${KERNEL_BUSY_INDICATOR}

atest/07_Configuration.robot

@@ -38,7 +38,7 @@ LaTeX
     [Tags]    language:latex
     ${needs reload} =    Set Variable    "${OS}" == "Windows"
     Settings Should Change Editor Diagnostics    LaTeX    example.tex    texlab
-    ...    {"chktex.onOpenAndSave": true}
+    ...    {"chktex.onOpenAndSave": true, "chktex.onEdit": true}
     ...    ${EMPTY}
     ...    Command terminated with space. (chktex)
     ...    Save File

atest/Keywords.resource

@@ -107,7 +107,7 @@ Lab Log Should Not Contain Known Error Messages
 Wait For Splash
     Go To    ${URL}lab?reset&token=${TOKEN}
     Set Window Size    1024    768
-    Wait Until Page Contains Element    ${SPLASH}    timeout=30s
+    Wait Until Page Contains Element    ${SPLASH}    timeout=45s
     Wait Until Page Does Not Contain Element    ${SPLASH}    timeout=10s
     Execute Javascript    window.onbeforeunload \= function (){}
 
@@ -375,7 +375,7 @@ Open in Advanced Settings
         Lab Command    Advanced Settings Editor
     END
     ${sel} =    Set Variable    css:[data-id="${plugin id}"]
-    Wait Until Page Contains Element    ${sel}
+    Wait Until Page Contains Element    ${sel}    timeout=10s
     Click Element    ${sel}
     Wait Until Page Contains    System Defaults
 

binder/environment.yml

@@ -7,7 +7,7 @@ channels:
 dependencies:
   # runtime dependencies
   - python >=3.7,<3.11.0a0
-  - jupyterlab >=3.1.0,<4.0.0a0
+  - jupyterlab >=3.3.0,<4.0.0a0
   - jupyter_server >=1.1.2
   - retrolab >=0.3.0,<0.4
   # build dependencies

docs/rtd.yml

@@ -7,7 +7,7 @@ channels:
 
 dependencies:
   - importlib_metadata
-  - jupyterlab >=3.1.0,<4.0.0a0
+  - jupyterlab >=3.3.0,<4.0.0a0
   - myst-nb
   - nodejs >=14,!=15,<17
   - pandas

packages/jupyterlab-lsp/package.json

@@ -67,7 +67,7 @@
   },
   "devDependencies": {
     "@babel/preset-env": "^7.4.3",
-    "@jupyterlab/application": "^3.1.0",
+    "@jupyterlab/application": "^3.3.0",
     "@jupyterlab/apputils": "^3.1.0",
     "@jupyterlab/builder": "^3.1.0",
     "@jupyterlab/cells": "^3.1.0",
@@ -85,6 +85,7 @@
     "@jupyterlab/statusbar": "^3.1.0",
     "@jupyterlab/testutils": "^3.1.0",
     "@jupyterlab/tooltip": "^3.1.0",
+    "@jupyterlab/ui-components": "^3.3.0",
     "@lumino/algorithm": "*",
     "@lumino/widgets": "^1.16.1",
     "@retrolab/application": "^0.2.0",
@@ -108,7 +109,7 @@
     "vscode-languageserver-protocol": "^3.16.0"
   },
   "peerDependencies": {
-    "@jupyterlab/application": "^3.1.0",
+    "@jupyterlab/application": "^3.3.0",
     "@jupyterlab/apputils": "^3.1.0",
     "@jupyterlab/cells": "^3.1.0",
     "@jupyterlab/codeeditor": "^3.1.0",