Skip to content

Commit 66ca146

Browse files
authored
Merge pull request #14 from jtpio/fix-nbdime-args
Fix args for `jupyterlab-cell-diff:show-nbdime`
2 parents efa2e44 + 4bce108 commit 66ca146

File tree

4 files changed

+6
-17
lines changed

4 files changed

+6
-17
lines changed
Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
2-
from typing import Literal, Optional
1+
from typing import Literal
32
from typing_extensions import TypedDict
4-
from nbdime.diffing.generic import diff
53

64

75
COMMAND_NAME = "jupyterlab-cell-diff:show-nbdime"
@@ -19,18 +17,12 @@ class ShowDiff(TypedDict):
1917
args: MergeDiff
2018

2119

22-
def show_diff(
23-
cell_id: str,
24-
original_source: str,
25-
new_source: str
26-
) -> ShowDiff:
27-
diff_results = diff(original_source, new_source)
20+
def show_diff(cell_id: str, original_source: str, new_source: str) -> ShowDiff:
2821
return {
2922
"name": COMMAND_NAME,
3023
"args": {
31-
"cell_id": cell_id,
32-
"original_source": original_source,
33-
"diff": diff_results
34-
}
24+
"cellId": cell_id,
25+
"originalSource": original_source,
26+
"newSource": new_source,
27+
},
3528
}
36-

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
"jupyterlab-cell-diff": "^0.4.2",
7878
"jupyterlab-cell-input-footer": "^0.3.1",
7979
"jupyterlab-eventlistener": "^0.4.0",
80-
"nbdime": "^7.0.1",
8180
"react": "^18.2.0"
8281
},
8382
"devDependencies": {

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ dependencies = [
2828
"jupyterlab-cell-diff>=0.4.2",
2929
"jupyterlab-cell-input-footer>=0.3.1",
3030
"importlib_metadata",
31-
"nbdime",
3231
"cachetools",
3332
"langchain",
3433
"langgraph",

yarn.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4725,7 +4725,6 @@ __metadata:
47254725
jupyterlab-cell-input-footer: ^0.3.1
47264726
jupyterlab-eventlistener: ^0.4.0
47274727
mkdirp: ^1.0.3
4728-
nbdime: ^7.0.1
47294728
npm-run-all: ^4.1.5
47304729
prettier: ^3.0.0
47314730
react: ^18.2.0

0 commit comments

Comments
 (0)