Report tests as skipped in dry-run mode

Reporting them as successful seems misleading

Author: marcphilipp

documentation/src/docs/asciidoc/user-guide/advanced-topics/launcher-api.adoc

@@ -272,6 +272,6 @@ When running tests via the `{Launcher}` API, you can enable _dry-run mode_ by se
 `junit.platform.execution.dryRun.enabled` <<running-tests-config-params,
 configuration parameter>> to `true`. In this mode, the `{Launcher}` will not actually
 execute any tests but will notify registered `{TestExecutionListener}` instances as if all
-tests had been executed successfully. This can be useful to test changes in the
-configuration of a build or to verify a listener is called as expected without having to
-wait for all tests to be executed.
+tests had been skipped and their containers had been successful. This can be useful to
+test changes in the configuration of a build or to verify a listener is called as expected
+without having to wait for all tests to be executed.

junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java

@@ -153,11 +153,11 @@ public class LauncherConstants {
 	 *
 	 * <p>When dry-run mode is enabled, no tests will be executed. Instead, all
 	 * registered {@link TestExecutionListener TestExecutionListeners} will
-	 * receive started/finished events for all test descriptors that are part
-	 * of the discovered {@link TestPlan}. All tests will be reported as
-	 * successful. This can be useful to test changes in the configuration of a
-	 * build or to verify a listener is called as expected without having to
-	 * wait for all tests to be executed.
+	 * receive events for all test descriptors that are part of the discovered
+	 * {@link TestPlan}. All containers will be reported as successful and all
+	 * tests as skipped. This can be useful to test changes in the configuration
+	 * of a build or to verify a listener is called as expected without having
+	 * to wait for all tests to be executed.
 	 *
 	 * <p>Value must be either {@code true} or {@code false}; defaults to {@code false}.
 	 */

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/EngineExecutionOrchestrator.java

@@ -110,8 +110,7 @@ public void preVisitContainer(TestIdentifier testIdentifier) {
 			@Override
 			public void visit(TestIdentifier testIdentifier) {
 				if (!testIdentifier.isContainer()) {
-					listener.executionStarted(testIdentifier);
-					listener.executionFinished(testIdentifier, TestExecutionResult.successful());
+					listener.executionSkipped(testIdentifier, "JUnit Platform dry-run mode is enabled");
 				}
 			}
 

platform-tests/src/test/java/org/junit/platform/launcher/core/DefaultLauncherTests.java

@@ -646,8 +646,7 @@ void dryRunModeReportsEventsForAllTestsButDoesNotExecuteThem() {
 		inOrder.verify(listener).testPlanExecutionStarted(any());
 		inOrder.verify(listener).executionStarted(TestIdentifier.from(engine.getEngineDescriptor()));
 		inOrder.verify(listener).executionStarted(TestIdentifier.from(container));
-		inOrder.verify(listener).executionStarted(TestIdentifier.from(test));
-		inOrder.verify(listener).executionFinished(TestIdentifier.from(test), successful());
+		inOrder.verify(listener).executionSkipped(TestIdentifier.from(test), "JUnit Platform dry-run mode is enabled");
 		inOrder.verify(listener).executionFinished(TestIdentifier.from(container), successful());
 		inOrder.verify(listener).executionFinished(TestIdentifier.from(engine.getEngineDescriptor()), successful());
 		inOrder.verify(listener).testPlanExecutionFinished(any());