Merge branch 'master' into type-inf-improvements

Author: pfitzseb

src/StaticLint.jl

@@ -293,7 +293,7 @@ function get_path(x::EXPR, state)
                         seterror!(arg, IncludePathContainsNULL)
                         return ""
                     end
-                    push!(path_elements, string(valofid(arg)))
+                    push!(path_elements, string(valof(arg)))
                 else
                     return ""
                 end

src/bindings.jl

@@ -354,7 +354,7 @@ function add_binding(x, state, scope=state.scope)
             check_const_decl(name, b, scope)
 
             scope.names[name] = b
-        elseif is_soft_scope(scope) && parentof(scope) isa Scope && scopehasbinding(parentof(scope), valofid(b.name)) && !enforce_hard_scope(x, scope)
+        elseif is_soft_scope(scope) && parentof(scope) isa Scope && isidentifier(b.name) && scopehasbinding(parentof(scope), valofid(b.name)) && !enforce_hard_scope(x, scope)
             add_binding(x, state, scope.parent)
         else
             scope.names[name] = b

src/linting/checks.jl

@@ -504,7 +504,7 @@ function check_farg_unused_(arg, arg_names)
         # only self ref:
        (length(b.refs) == 1 && first(b.refs) == b.name) ||
         # first usage is assignment:
-       (length(b.refs) > 1 && CSTParser.hasparent(b.refs[2]) && isassignment(parentof(b.refs[2])) && parentof(b.refs[2]).args[1] == b.refs[2])
+       (length(b.refs) > 1 && b.refs[2] isa EXPR && CSTParser.hasparent(b.refs[2]) && isassignment(parentof(b.refs[2])) && parentof(b.refs[2]).args[1] == b.refs[2])
         seterror!(arg, UnusedFunctionArgument)
     end