Merge pull request #374 from julia-vscode/sp/macro-definition-sites

fix: correctly follow find definitions for macros

Author: pfitzseb

src/linting/checks.jl

@@ -337,7 +337,7 @@ function sig_match_any(func::EXPR, x, call_counts, tls::Scope, env::ExternalEnv)
 end
 
 function get_method(name::EXPR)
-    f = maybe_get_parent_fexpr(name, x -> CSTParser.defines_function(x) || CSTParser.defines_struct(x))
+    f = maybe_get_parent_fexpr(name, x -> CSTParser.defines_function(x) || CSTParser.defines_struct(x) || CSTParser.defines_macro(x))
     if f !== nothing && CSTParser.get_name(f) == name
         return f
     end

test/runtests.jl

@@ -2005,3 +2005,26 @@ end
     """)
     @test isempty(StaticLint.collect_hints(cst, server))
 end
+
+@testset "macro definition" begin
+    cst = parse_and_pass("""
+    module JumpToMacroDoesNotWork
+        export @mymacro
+
+        macro mymacro()
+        end
+    end
+
+    JumpToMacroDoesNotWork.@mymacro(1+1)
+    """)
+    m = cst.args[end].args[1].args[2].args[1]
+    methods = Set()
+    for r in m.meta.ref.refs
+        m = StaticLint.get_method(r)
+        if m !== nothing
+            push!(methods, m)
+        end
+    end
+
+    @test !isempty(methods)
+end