Merge pull request #1308 from julia-vscode/change-file-client-cap

Use watch files client capability

Author: davidanthoff

src/protocol/configuration.jl

@@ -49,8 +49,17 @@ end
     changes::Vector{FileEvent}
 end
 
+const Pattern = String
+
+struct RelativePattern <: Outbound
+	baseUri::Union{WorkspaceFolder,URI}
+	pattern::Pattern
+end
+
+const GlobPattern = Union{Pattern,RelativePattern}
+
 struct FileSystemWatcher <: Outbound
-    globPattern::String
+    globPattern::GlobPattern
     kind::Union{WatchKind,Missing}
 end
 

src/protocol/initialize.jl

@@ -23,6 +23,7 @@ end
 
 @dict_readable struct DidChangeWatchedFilesClientCapabilities <: Outbound
     dynamicRegistration::Union{Bool,Missing}
+    relativePatternSupport::Union{Bool,Missing}
 end
 
 @dict_readable struct WorkspaceClientCapabilities <: Outbound

src/requests/init.jl

@@ -189,12 +189,39 @@ end
 function initialized_notification(params::InitializedParams, server::LanguageServerInstance, conn)
     server.status = :running
 
+    client_capabilities_registrations = Registration[]
+
     if server.clientcapability_workspace_didChangeConfiguration
+        push!(
+            client_capabilities_registrations,
+            Registration(string(uuid4()), "workspace/didChangeConfiguration", missing)
+        )
+    end
+
+    if !ismissing(server.clientCapabilities) &&
+        !ismissing(server.clientCapabilities.workspace) &&
+        !ismissing(server.clientCapabilities.workspace.didChangeWatchedFiles) &&
+        !ismissing(server.clientCapabilities.workspace.didChangeWatchedFiles.dynamicRegistration) &&
+        !ismissing(server.clientCapabilities.workspace.didChangeWatchedFiles.relativePatternSupport) &&
+        server.clientCapabilities.workspace.didChangeWatchedFiles.dynamicRegistration &&
+        server.clientCapabilities.workspace.didChangeWatchedFiles.relativePatternSupport
+
+        push!(
+            client_capabilities_registrations,
+            Registration("workspace/didChangeWatchedFiles", "workspace/didChangeWatchedFiles", DidChangeWatchedFilesRegistrationOptions([
+                FileSystemWatcher("**/*.{jl,jmd,md}", missing),
+                FileSystemWatcher("**/{Project.toml,JuliaProject.toml,Manifest.toml,JuliaManifest.toml,.JuliaLint.toml}", missing)
+            ]))
+        )
+    end
+
+    if length(client_capabilities_registrations) > 0
         JSONRPC.send(
             conn,
             client_registerCapability_request_type,
-            RegistrationParams([Registration(string(uuid4()), "workspace/didChangeConfiguration", missing)])
+            RegistrationParams(client_capabilities_registrations)
         )
+
     end
 
     JuliaWorkspaces.mark_current_diagnostics(server.workspace)

test/test_shared_init_request.jl

@@ -11,7 +11,7 @@ init_request = LanguageServer.InitializeParams(
                 true,
                 LanguageServer.WorkspaceEditClientCapabilities(true, missing, missing),
                 LanguageServer.DidChangeConfigurationClientCapabilities(false),
-                LanguageServer.DidChangeWatchedFilesClientCapabilities(false,),
+                LanguageServer.DidChangeWatchedFilesClientCapabilities(false,false),
                 LanguageServer.WorkspaceSymbolClientCapabilities(true, missing),
                 LanguageServer.ExecuteCommandClientCapabilities(true),
                 missing,