Merge pull request #828 from julia-vscode/improve-errors

Add better error message

Author: davidanthoff

src/document.jl

@@ -63,7 +63,7 @@ end
 """
     get_offset(doc, line, char)
 
-Returns the byte offset position corresponding to a line/character position. 
+Returns the byte offset position corresponding to a line/character position.
 This takes 0 based line/char inputs. Corresponding functions are available for
 Position and Range arguments, the latter returning a UnitRange{Int}.
 """
@@ -101,10 +101,10 @@ function get_offset2(doc::Document, line::Integer, character::Integer)
     text = get_text(doc)
 
     if line >= length(line_offsets)
-        error("Invalid arguments.")
+        throw(LSOffsetError("get_offset2 crashed. More diagnostics:\nline=$line\nline_offsets='$line_offsets'"))
         return nextind(text, lastindex(text))
     elseif line < 0
-        error("Invalid arguments.")
+        throw(LSOffsetError("get_offset2 crashed. More diagnostics:\nline=$line\nline_offsets='$line_offsets'"))
     end
 
     line_offset = line_offsets[line + 1]
@@ -153,9 +153,9 @@ end
 
 """
     get_line_offsets(doc::Document)
-    
-Updates the doc._line_offsets field, an n length Array each entry of which 
-gives the byte offset position of the start of each line. This always starts 
+
+Updates the doc._line_offsets field, an n length Array each entry of which
+gives the byte offset position of the start of each line. This always starts
 with 0 for the first line (even if empty).
 """
 function get_line_offsets(doc::Document, force=false)

test/test_document.jl

@@ -64,7 +64,7 @@ d6 = Document("untitled", s6, false)
     LS.applytextdocumentchanges(doc, c3)
     @test LS.get_text(doc) == "println(\"Hello World\")"
     # doc currently has only one line, applying change to 2nd line should throw
-    @test_throws ErrorException LS.applytextdocumentchanges(doc, c2)
+    @test_throws LanguageServer.LSOffsetError LS.applytextdocumentchanges(doc, c2)
 end
 
 @testset "UTF16 handling" begin