Refactor repeated linting steps into helper function

Author: non-Jedi

src/languageserverinstance.jl

@@ -264,10 +264,7 @@ function Base.run(server::LanguageServerInstance)
                     scopepass(root, doc)
                 end
 
-                StaticLint.check_all(getcst(doc), server.lint_options, server)
-                empty!(doc.diagnostics)
-                mark_errors(doc, doc.diagnostics)
-                publish_diagnostics(doc, server)
+                lint!(doc, server)
             end
         end
     end

src/requests/textdocument.jl

@@ -80,10 +80,7 @@ function process(r::JSONRPC.Request{Val{Symbol("textDocument/didChange")},DidCha
         tdcce = first(r.params.contentChanges)
         new_cst = _partial_update(doc, tdcce) 
         scopepass(getroot(doc), doc)
-        StaticLint.check_all(getcst(doc), server.lint_options, server)
-        empty!(doc.diagnostics)
-        mark_errors(doc, doc.diagnostics)
-        publish_diagnostics(doc, server)
+        lint!(doc, server)
     else
         for tdcce in r.params.contentChanges
             applytextdocumentchanges(doc, tdcce)
@@ -234,11 +231,7 @@ function parse_all(doc::Document, server::LanguageServerInstance)
     end
 
     scopepass(getroot(doc), doc)
-    StaticLint.check_all(getcst(doc), server.lint_options, server)
-    empty!(doc.diagnostics)
-    mark_errors(doc, doc.diagnostics)
-    
-    publish_diagnostics(doc, server)
+    lint!(doc, server)
 end
 
 function mark_errors(doc, out = Diagnostic[])

src/requests/workspace.jl

@@ -111,11 +111,7 @@ function request_julia_config(server::LanguageServerInstance)
 
     if rerun_lint
         for doc in getdocuments_value(server)
-            # TODO: wrap next 4 lines in function since it's repeated throughout project
-            StaticLint.check_all(getcst(doc), server.lint_options, server)
-            empty!(doc.diagnostics)
-            mark_errors(doc, doc.diagnostics)
-            publish_diagnostics(doc, server)
+            lint!(doc, server)
         end
     end
 

src/staticlint.jl

@@ -56,4 +56,11 @@ getserver(file::Document) = file.server
 function setserver(file::Document, server::LanguageServerInstance)
     file.server = server
     return file
-end
+end
+
+function lint!(doc, server)
+    StaticLint.check_all(getcst(doc), server.lint_options, server)
+    empty!(doc.diagnostics)
+    mark_errors(doc, doc.diagnostics)
+    publish_diagnostics(doc, server)
+end