change function based views to generic views on movie app

Author: Juan Benitez

.vscode/settings.json

@@ -0,0 +1,4 @@
+{
+    "python.linting.pylintEnabled": true,
+    "python.pythonPath": "env\\Scripts\\python.exe"
+}

api_crud/settings.py

@@ -29,7 +29,7 @@
 
 REST_FRAMEWORK = {
     'DEFAULT_AUTHENTICATION_CLASSES': (
-        'api_crud.authentication.JWTAuthentication',
+        'rest_framework.authentication.TokenAuthentication',
     )
 }
 

db.sqlite3

@@ -21,10 +21,8 @@ class IsAuthenticated(permissions.BasePermission):
     """
     Allows access only to authenticated users.
     """
-    print("df")
-
     def has_permission(self, request, view):
-        message = 'No estas autenticado mi vale!'
+        message = 'You must be authenticated'
         is_it = bool(request.user and request.user.is_authenticated)
         if is_it:
             return is_it

movies/permissions.py

@@ -3,16 +3,15 @@
 from django.contrib.auth.models import User
 
 
-
-class MovieSerializer(serializers.ModelSerializer): # create classs to serializer model
+class MovieSerializer(serializers.ModelSerializer):  # create class to serializer model
     creator = serializers.ReadOnlyField(source='creator.username')
 
     class Meta:
         model = Movie
         fields = ('title', 'genre', 'year', 'creator')
 
 
-class UserSerializer(serializers.ModelSerializer): #create class to serealizer usermodel
+class UserSerializer(serializers.ModelSerializer):  # create class to serializer usermodel
     movies = serializers.PrimaryKeyRelatedField(many=True, queryset=Movie.objects.all())
 
     class Meta:

movies/serializers.py

@@ -4,12 +4,12 @@
 
 urlpatterns = [
     url(r'^api/v1/movies/(?P<pk>[0-9]+)$', # urls with details i.e /movies/(1-9)
-        views.get_delete_update_movie,
+        views.get_delete_update_movie.as_view(),
         name='get_delete_update_movie'
     ),
     url(
         r'^api/v1/movies/$', # urls list all and create new one
-        views.get_post_movies,
+        views.get_post_movies.as_view(),
         name='get_post_movies'
     )
 ]

movies/urls.py

@@ -1,67 +1,78 @@
-from rest_framework.decorators import api_view, permission_classes
-from rest_framework.response import Response
 from rest_framework import status
-from rest_framework.parsers import JSONParser
+from rest_framework.response import Response
+from rest_framework.generics import RetrieveUpdateDestroyAPIView, ListCreateAPIView
 from .models import Movie
-from .serializers import MovieSerializer
 from .permissions import IsOwnerOrReadOnly, IsAuthenticated
+from .serializers import MovieSerializer
 
+class get_delete_update_movie(RetrieveUpdateDestroyAPIView):
+    permission_classes = (IsAuthenticated, IsOwnerOrReadOnly,)
 
-@api_view(['GET', 'DELETE', 'PUT']) # Methods Allowed
-@permission_classes((IsAuthenticated, IsOwnerOrReadOnly,)) # Pemissions, Only Authenticated user
-def get_delete_update_movie(request, pk):  #pk es PrimaryKey(Id)
-    try:
-        movie = Movie.objects.get(pk=pk)
-    except Movie.DoesNotExist:
-        content = {
-            'status': 'Not Found'
-        }
-        return Response(content, status=status.HTTP_404_NOT_FOUND)
+    def get_queryset(self, pk):
+        try:
+            movie = Movie.objects.get(pk=pk)
+        except Movie.DoesNotExist:
+            content = {
+                'status': 'Not Found'
+            }
+            return Response(content, status=status.HTTP_404_NOT_FOUND)
+        return movie
+
+    # Get a movie
+    def get(self, request, pk):
 
-    # details a sinlge movie
-    if request.method == 'GET':
+        movie = self.get_queryset(pk)
         serializer = MovieSerializer(movie)
-        return Response(serializer.data)
-    # delete a movie
-    elif request.method == 'DELETE':
+        return Response(serializer.data, status=status.HTTP_200_OK)
+
+    # Update a movie
+    def put(self, request, pk):
+        
+        movie = self.get_queryset(pk)
+
         if(request.user == movie.creator): # If creator is who makes request
-            movie.delete()
-            content = {
-                'status': 'NO CONTENT'
-            }
-            return Response(content, status=status.HTTP_204_NO_CONTENT)
+            serializer = MovieSerializer(movie, data=request.data)
+            if serializer.is_valid():
+                serializer.save()
+                return Response(serializer.data, status=status.HTTP_201_CREATED)
+            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
         else:
             content = {
                 'status': 'UNAUTHORIZED'
             }
             return Response(content, status=status.HTTP_401_UNAUTHORIZED)
-    # update a movie
-    elif request.method == 'PUT':
+
+    # Delete a movie
+    def delete(self, request, pk):
+
+        movie = self.get_queryset(pk)
+
         if(request.user == movie.creator): # If creator is who makes request
-            serializer = MovieSerializer(movie, data=request.data)
-            if serializer.is_valid():
-                serializer.save()
-                return Response(serializer.data, status=status.HTTP_201_CREATED)
-            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
+            movie.delete()
+            content = {
+                'status': 'NO CONTENT'
+            }
+            return Response(content, status=status.HTTP_204_NO_CONTENT)
         else:
             content = {
                 'status': 'UNAUTHORIZED'
             }
             return Response(content, status=status.HTTP_401_UNAUTHORIZED)
+   
+
+class get_post_movies(ListCreateAPIView):
+
+    permission_classes = (IsAuthenticated,)
+    # Get all movies
+    def get(self, request):
 
+        movies = Movie.objects.all()
+        serializer = MovieSerializer(movies, many=True)
+        return Response(serializer.data, status=status.HTTP_200_OK)
 
-@api_view(['GET', 'POST'])
-@permission_classes((IsAuthenticated, ))
-def get_post_movies(request):
-    print('adasd')
-    # get all movies
-    if request.method == 'GET':
-        puppies = Movie.objects.all()
-        serializer = MovieSerializer(puppies, many=True)
-        return Response(serializer.data)
+    # Create a new movie
+    def post(self, request):
 
-    # create a new movie
-    elif request.method == 'POST':
         serializer = MovieSerializer(data=request.data)
         if serializer.is_valid():
             serializer.save(creator=request.user)