Add tests for filters.

Author: nat-henderson

spec/commands/check_spec.rb

@@ -17,10 +17,17 @@ def stub_json(uri, body)
       .to_return(headers: { 'Content-Type' => 'application/json' }, body: body.to_json)
   end
 
+  def stub_prs(uri, body)
+    stub_json(uri, body)
+    body.each do |pr|
+      stub_json(uri.sub('pulls', 'pulls/' + pr[:number].to_s).sub('&per_page=100', ''), pr)
+    end
+  end
+
   context 'when targetting a base branch other than master' do
     before do
       stub_json('https://api.github.com/repos/jtarchie/test/statuses/abcdef', [])
-      stub_json('https://api.github.com:443/repos/jtarchie/test/pulls?base=my-base-branch&direction=asc&per_page=100&sort=updated&state=open', [{ number: 1, head: { sha: 'abcdef' } }])
+      stub_prs('https://api.github.com:443/repos/jtarchie/test/pulls?base=my-base-branch&direction=asc&per_page=100&sort=updated&state=open', [{ number: 1, head: { sha: 'abcdef' } }])
     end
 
     it 'retrieves pull requests for the specified base branch' do
@@ -48,7 +55,7 @@ def stub_json(uri, body)
 
   context 'when there is an open pull request' do
     before do
-      stub_json('https://api.github.com:443/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open', [{ number: 1, head: { sha: 'abcdef' } }])
+      stub_prs('https://api.github.com:443/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open', [{ number: 1, head: { sha: 'abcdef' } }])
     end
 
     it 'returns SHA of the pull request' do
@@ -79,7 +86,7 @@ def stub_json(uri, body)
 
   context 'when there is more than one open pull request' do
     before do
-      stub_json('https://api.github.com/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open', [
+      stub_prs('https://api.github.com/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open', [
                   { number: 1, head: { sha: 'abcdef', repo: { full_name: 'jtarchie/test' } }, base: { repo: { full_name: 'jtarchie/test' } } },
                   { number: 2, head: { sha: 'zyxwvu', repo: { full_name: 'someotherowner/repo' } }, base: { repo: { full_name: 'jtarchie/test' } } }
                 ])
@@ -119,7 +126,9 @@ def stub_cache_json(uri)
       end
 
       stub_body_json('https://api.github.com/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open', pull_requests[0..49], 'Link' => '<https://api.github.com/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open&page=2>; rel="next"')
+      stub_prs('https://api.github.com/repos/jtarchie/test/pulls?direction=asc&sort=updated&state=open', pull_requests[0..49])
       stub_body_json('https://api.github.com/repos/jtarchie/test/pulls?direction=asc&per_page=100&sort=updated&state=open&page=2', pull_requests[50..99])
+      stub_prs('https://api.github.com/repos/jtarchie/test/pulls?direction=asc&sort=updated&state=open', pull_requests[50..99])
 
       first_prs = check('source' => { 'repo' => 'jtarchie/test' })
       expect(first_prs.length).to eq 100

spec/filters/approval_spec.rb

@@ -0,0 +1,79 @@
+require_relative '../../assets/lib/filters/approval'
+require_relative '../../assets/lib/pull_request'
+require_relative '../../assets/lib/input'
+require 'webmock/rspec'
+
+describe Filters::Approval do
+  let(:ignore_pr) do
+    PullRequest.new(pr: { 'number' => 1, 'head' => { 'sha' => 'abc' }, 'author_association' => 'NONE',
+                          'base' => { 'repo' => {'full_name' => 'user/repo', 'permissions' => {'push' => true} } } })
+  end
+
+  let(:pr) do
+    PullRequest.new(pr: { 'number' => 2, 'head' => { 'sha' => 'def' }, 'author_association' => 'OWNER',
+                          'base' => { 'repo' => {'full_name' => 'user/repo', 'permissions' => {'push' => true} } } })
+  end
+
+  let(:pull_requests) { [ignore_pr, pr] }
+
+  def stub_json(uri, body)
+    stub_request(:get, uri)
+      .to_return(headers: { 'Content-Type' => 'application/json' }, body: body.to_json)
+  end
+
+  context 'when all approval requirements are disabled' do
+    it 'does not filter' do
+      payload = { 'source' => { 'repo' => 'user/repo' } }
+      filter = described_class.new(pull_requests: pull_requests, input: Input.instance(payload: payload))
+
+      expect(filter.pull_requests).to eq pull_requests
+    end
+
+    it 'does not filter when explictly disabled' do
+      payload = { 'source' => { 'repo' => 'user/repo', 'require_manual_approval' => false, 'require_review_approval' => false, 'authorship_restriction' => false } }
+      filter = described_class.new(pull_requests: pull_requests, input: Input.instance(payload: payload))
+
+      expect(filter.pull_requests).to eq pull_requests
+    end
+  end
+  
+  context 'when owner filtering is enabled' do
+    it 'only returns PRs that are repo-owners' do
+      payload = { 'source' => { 'repo' => 'user/repo', 'require_manual_approval' => false, 'require_review_approval' => false, 'authorship_restriction' => true } }
+      filter = described_class.new(pull_requests: pull_requests, input: Input.instance(payload: payload))
+
+      expect(filter.pull_requests).to eq [pr]
+    end
+  end
+
+  context 'when approval filtering is enabled' do
+    before do
+      stub_json(%r{https://api.github.com/repos/user/repo/pulls/1/reviews}, [{ 'state' => 'CHANGES_REQUESTED' }])
+      stub_json(%r{https://api.github.com/repos/user/repo/pulls/2/reviews}, [{ 'state' => 'APPROVED' }])
+    end
+
+    it 'only returns PRs that are approved' do
+      payload = { 'source' => { 'repo' => 'user/repo', 'require_manual_approval' => false, 'require_review_approval' => true, 'authorship_restriction' => false } }
+      filter = described_class.new(pull_requests: pull_requests, input: Input.instance(payload: payload))
+
+      expect(filter.pull_requests).to eq [pr]
+    end
+  end
+
+  context 'when manual approval filtering is enabled' do
+    before do
+      stub_json(%r{https://api.github.com/repos/user/repo/pulls/1/comments}, [{ 'author_association' => 'OWNER', 'body' => 'other comment' },
+                                                                              { 'author_association' => 'NONE', 'body' => 'ci ok' }])
+      stub_json(%r{https://api.github.com/repos/user/repo/pulls/2/comments}, [{ 'author_association' => 'OWNER', 'body' => 'ci ok' }])
+    end
+
+    it 'only returns PRs that are approved' do
+      payload = { 'source' => { 'repo' => 'user/repo', 'require_manual_approval' => true, 'require_review_approval' => false, 'authorship_restriction' => false } }
+      filter = described_class.new(pull_requests: pull_requests, input: Input.instance(payload: payload))
+
+      expect(filter.pull_requests).to eq [pr]
+    end
+  end
+
+
+end

spec/filters/mergeable_spec.rb

@@ -5,13 +5,11 @@
 
 describe Filters::Mergeable do
   let(:ignore_pr) do
-    PullRequest.new(pr: { 'number' => 1, 'head' => { 'sha' => 'abc' }, 'mergeable' => false,
-                          'base' => { 'repo' => {'full_name' => 'user/repo', 'permissions' => {'push' => true} } } })
+    PullRequest.new(pr: { 'number' => 1, 'head' => { 'sha' => 'abc' }, 'mergeable' => false})
   end
 
   let(:pr) do
-    PullRequest.new(pr: { 'number' => 2, 'head' => { 'sha' => 'def' }, 'mergeable' => true ,
-                          'base' => { 'repo' => {'full_name' => 'user/repo', 'permissions' => {'push' => true} } } })
+    PullRequest.new(pr: { 'number' => 2, 'head' => { 'sha' => 'def' }, 'mergeable' => true})
   end
 
   let(:pull_requests) { [ignore_pr, pr] }