Remove 'manual approval' feature.

Author: nat-henderson

README.md

@@ -64,10 +64,6 @@ resource_types:
 * `require_review_approval`: *Optional*, default false.  If set to `true`, it will
   filter out pull requests that do not have an Approved review.
 
-* `require_manual_approval`: *Optional*, default false.  If set to `true`, it will
-  filter out pull requests, unless there is a comment on the PR containing the string
-  `ci ok`, from a collaborator, repo owner, or organization member.
-
 * `authorship_restriction`: *Optional*, default false.  If set to `true`, will only
   return PRs created by someone who is a collaborator, repo owner, or organization member.
 

assets/lib/filters/approval.rb

@@ -9,9 +9,6 @@ def pull_requests
       if @input.source.require_review_approval
         @pull_requests.delete_if {|x| !x.review_approved? }
       end
-      if @input.source.require_manual_approval
-        @pull_requests.delete_if {|x| !x.approved_by_collaborator? }
-      end
       if @input.source.authorship_restriction
         @pull_requests.delete_if {|x| !x.author_associated? }
       end

assets/lib/pull_request.rb

@@ -31,11 +31,6 @@ def author_associated?
     %w(OWNER COLLABORATOR MEMBER).include? @pr['author_association']
   end
 
-  def approved_by_collaborator?
-    Octokit.pull_comments(base_repo, id).any? {|c| (%w(OWNER COLLABORATOR MEMBER).include?(c['author_association']) &&
-                                                    c['body'].downcase.include?('ci ok')) }
-  end
-
   def equals?(id:, sha:)
     [self.sha, self.id.to_s] == [sha, id.to_s]
   end

spec/filters/approval_spec.rb

@@ -60,20 +60,4 @@ def stub_json(uri, body)
     end
   end
 
-  context 'when manual approval filtering is enabled' do
-    before do
-      stub_json(%r{https://api.github.com/repos/user/repo/pulls/1/comments}, [{ 'author_association' => 'OWNER', 'body' => 'other comment' },
-                                                                              { 'author_association' => 'NONE', 'body' => 'ci ok' }])
-      stub_json(%r{https://api.github.com/repos/user/repo/pulls/2/comments}, [{ 'author_association' => 'OWNER', 'body' => 'ci ok' }])
-    end
-
-    it 'only returns PRs that are approved' do
-      payload = { 'source' => { 'repo' => 'user/repo', 'require_manual_approval' => true, 'require_review_approval' => false, 'authorship_restriction' => false } }
-      filter = described_class.new(pull_requests: pull_requests, input: Input.instance(payload: payload))
-
-      expect(filter.pull_requests).to eq [pr]
-    end
-  end
-
-
 end