Expand no-array-index-key to other array iterator methods

Although some of these cover pretty unusual use-cases, they are easy
enough to support and are unlikely to have false positives.

Author: lencioni

docs/rules/no-array-index-key.md

@@ -14,6 +14,26 @@ The following patterns are considered warnings:
 things.map((thing, index) => (
   <Hello key={index} />
 ));
+
+things.forEach((thing, index) => {
+  otherThings.push(<Hello key={index} />);
+});
+
+things.filter((thing, index) => {
+  otherThings.push(<Hello key={index} />);
+});
+
+things.some((thing, index) => {
+  otherThings.push(<Hello key={index} />);
+});
+
+things.every((thing, index) => {
+  otherThings.push(<Hello key={index} />);
+});
+
+things.findIndex((thing, index) => {
+  otherThings.push(<Hello key={index} />);
+});
 ```
 
 The following patterns are not considered warnings:
@@ -22,4 +42,24 @@ The following patterns are not considered warnings:
 things.map((thing) => (
   <Hello key={thing.id} />
 ));
+
+things.forEach((thing) => {
+  otherThings.push(<Hello key={thing.id} />);
+});
+
+things.filter((thing) => {
+  otherThings.push(<Hello key={thing.id} />);
+});
+
+things.some((thing) => {
+  otherThings.push(<Hello key={thing.id} />);
+});
+
+things.every((thing) => {
+  otherThings.push(<Hello key={thing.id} />);
+});
+
+things.findIndex((thing) => {
+  otherThings.push(<Hello key={thing.id} />);
+});
 ```

lib/rules/no-array-index-key.js

@@ -24,6 +24,15 @@ module.exports = {
     // Public
     // --------------------------------------------------------------------------
     var indexParamNames = [];
+    var iteratorFunctionNames = [
+      'every',
+      'filter',
+      'find',
+      'findIndex',
+      'forEach',
+      'map',
+      'some'
+    ];
     var ERROR_MESSAGE = 'Do not use Array index in keys';
 
     function isArrayIndex(node) {
@@ -39,7 +48,7 @@ module.exports = {
       if (callee.property.type !== 'Identifier') {
         return null;
       }
-      if (callee.property.name !== 'map') {
+      if (iteratorFunctionNames.indexOf(callee.property.name) === -1) {
         return null;
       }
 

tests/lib/rules/no-array-index-key.js

@@ -93,6 +93,42 @@ ruleTester.run('no-array-index-key', rule, {
       parserOptions: parserOptions
     },
 
+    {
+      code: 'foo.forEach((bar, i) => { baz.push(<Foo key={i} />); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.filter((bar, i) => { baz.push(<Foo key={i} />); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.some((bar, i) => { baz.push(<Foo key={i} />); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.every((bar, i) => { baz.push(<Foo key={i} />); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.find((bar, i) => { baz.push(<Foo key={i} />); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.findIndex((bar, i) => { baz.push(<Foo key={i} />); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
     {
       code: 'foo.map((bar, i) => React.createElement(\'Foo\', { key: i }))',
       errors: [{message: 'Do not use Array index in keys'}],
@@ -115,6 +151,42 @@ ruleTester.run('no-array-index-key', rule, {
       code: 'foo.map((bar, i) => React.createElement(\'Foo\', { key: \'foo-\' + i + \'-bar\' }))',
       errors: [{message: 'Do not use Array index in keys'}],
       parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.forEach((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.filter((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.some((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.every((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.find((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
+    },
+
+    {
+      code: 'foo.findIndex((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
+      errors: [{message: 'Do not use Array index in keys'}],
+      parserOptions: parserOptions
     }
   ]
 });