Merge pull request #1406 from jseminck/no-typos-bug

Fix crash for no-typos: Cannot read property 'name' of undefined

Author: ljharb

lib/rules/no-typos.js

@@ -117,13 +117,21 @@ module.exports = {
       },
 
       MemberExpression: function(node) {
+        const propertyName = node.property.name;
+
+        if (
+          !propertyName ||
+          STATIC_CLASS_PROPERTIES.map(prop => prop.toLocaleLowerCase()).indexOf(propertyName.toLowerCase()) === -1
+        ) {
+          return;
+        }
+
         const relatedComponent = utils.getRelatedComponent(node);
 
         if (
           relatedComponent &&
           (utils.isES6Component(relatedComponent.node) || utils.isReturningJSX(relatedComponent.node))
         ) {
-          const propertyName = node.property.name;
           reportErrorIfClassPropertyCasingTypo(node, propertyName);
         }
       },

lib/util/Components.js

@@ -537,7 +537,7 @@ function componentRule(rule, context) {
           continue;
         }
         for (k = 0, l = componentNode.properties.length; k < l; k++) {
-          if (componentNode.properties[k].key.name === componentPath[i]) {
+          if (componentNode.properties[k].key && componentNode.properties[k].key.name === componentPath[i]) {
             componentNode = componentNode.properties[k];
             break;
           }

tests/lib/rules/no-typos.js

@@ -336,6 +336,14 @@ ruleTester.run('no-typos', rule, {
    `,
     parser: 'babel-eslint',
     parserOptions: parserOptions
+  }, {
+    code: `
+      const fn = (err, res) => {
+        const { body: data = {} } = { ...res };
+        data.time = data.time || {};
+      };
+    `,
+    parser: 'babel-eslint'
   }],
 
   invalid: [{