Modified no-did-X-set-state rules to enforce only for direct calls to this.setState; references/assignment are allowed.

Extra credit: ensure the reference is not used to be called thereafter. (not part of this commit.)

Author: benmosher

lib/rules/no-did-mount-set-state.js

@@ -16,16 +16,20 @@ module.exports = function(context) {
 
   return {
 
-    'MemberExpression': function(node) {
-      if (node.object.type !== 'ThisExpression' || node.property.name !== 'setState') {
+    'CallExpression': function(node) {
+      var callee = node.callee;
+      if (callee.type !== 'MemberExpression') {
         return;
       }
-      var ancestors = context.getAncestors(node);
+      if (callee.object.type !== 'ThisExpression' || callee.property.name !== 'setState') {
+        return;
+      }
+      var ancestors = context.getAncestors(callee);
       for (var i = 0, j = ancestors.length; i < j; i++) {
         if (ancestors[i].type !== 'Property' || ancestors[i].key.name !== 'componentDidMount') {
           continue;
         }
-        context.report(node, 'Do not use setState in componentDidMount');
+        context.report(callee, 'Do not use setState in componentDidMount');
       }
     }
   };

lib/rules/no-did-update-set-state.js

@@ -16,16 +16,20 @@ module.exports = function(context) {
 
   return {
 
-    'MemberExpression': function(node) {
-      if (node.object.type !== 'ThisExpression' || node.property.name !== 'setState') {
+    'CallExpression': function(node) {
+      var callee = node.callee;
+      if (callee.type !== 'MemberExpression') {
         return;
       }
-      var ancestors = context.getAncestors(node);
+      if (callee.object.type !== 'ThisExpression' || callee.property.name !== 'setState') {
+        return;
+      }
+      var ancestors = context.getAncestors(callee);
       for (var i = 0, j = ancestors.length; i < j; i++) {
         if (ancestors[i].type !== 'Property' || ancestors[i].key.name !== 'componentDidUpdate') {
           continue;
         }
-        context.report(node, 'Do not use setState in componentDidUpdate');
+        context.report(callee, 'Do not use setState in componentDidUpdate');
       }
     }
   };

tests/lib/rules/no-did-mount-set-state.js

@@ -40,6 +40,19 @@ eslintTester.addRuleTest('lib/rules/no-did-mount-set-state', {
             ecmaFeatures: {
               jsx: true
             }
+        }, {
+            code: '\
+              var Hello = React.createClass({\
+                componentDidMount: function() {\
+                  this.someHandler = this.setState;\
+                },\
+                render: function() {\
+                  return <div>Hello {this.props.name}</div>;\
+                }\
+              });',
+            ecmaFeatures: {
+              jsx: true
+            }
         }
     ],
 

tests/lib/rules/no-did-update-set-state.js

@@ -40,6 +40,19 @@ eslintTester.addRuleTest('lib/rules/no-did-update-set-state', {
             ecmaFeatures: {
               jsx: true
             }
+        }, {
+            code: '\
+              var Hello = React.createClass({\
+                componentDidUpdate: function() {\
+                  this.someHandler = this.setState;\
+                },\
+                render: function() {\
+                  return <div>Hello {this.props.name}</div>;\
+                }\
+              });',
+            ecmaFeatures: {
+              jsx: true
+            }
         }
     ],