chore: Update PMD

This patch bumps the Maven PMD plugin from 3.13.0 -> 3.16.0 as well
as the version of PMD used by the Maven PMD plugin, from
6.28.0 -> 6.43.0. This matches the version of PMD used by the
latest stable pmd-eclipse-plugin (4.32.0).

This patch removes deprecated rules from the PMD ruleset, and updates
the source where necessary to account for new rules.

Author: dmaccormack

SuppressWarnings.md

@@ -34,6 +34,7 @@ make it harder to follow the logic due to the additional indirection.
     // See SuppressWarnings.md#complexity
     "PMD.CyclomaticComplexity",
     "PMD.NPathComplexity",
+    "PMD.CognitiveComplexity",
     "java:S3776"
 })
 ```
@@ -85,4 +86,11 @@ couldn't find a PMD parameter that allows me to change the regex.
 ```java
 @SuppressWarnings({"PMD.GenericsNaming", "java:S119"}) // See SuppressWarnings.md
 ```
+## Duplicate Literals
 
+Though it is generally good to avoid duplicate literals, inline literals in
+unit tests often makes them much easier to read.
+
+```java
+@SuppressWarnings("PMD.AvoidDuplicateLiterals") // See SuppressWarnings.md
+```

config/pmd-ruleset.xml

@@ -82,7 +82,7 @@ public void setMaxParseValues(int maxParseValues) {
 
     @Override
     public int hashCode() {
-        final int prime = 31;
+        final int prime = 31; // NOPMD - AvoidFinalLocalVariable
         int result = 1;
         result = prime * result + (int) (maxParseChars ^ (maxParseChars >>> 32));
         result = prime * result + maxParseDepth;

module/jsonurl-core/src/main/java/org/jsonurl/Limits.java

@@ -120,23 +120,23 @@ protected String typeDescription() {
     @Override
     @SuppressWarnings("java:S1117") // See SuppressWarnings.md
     public String toString() {
-        StringBuilder buf = new StringBuilder(64);
+        final StringBuilder buf = new StringBuilder(64);
 
         buf.append("jsonurl ")
             .append(typeDescription())
             .append(": ")
             .append(getMessage());
 
-        int line = getLineNumber();
+        final int line = getLineNumber();
         if (line > -1) {
             buf.append(" at ").append(line);
 
-            int col = getColumn();
+            final int col = getColumn();
             if (col > -1) {
                 buf.append(':').append(col);
             }
         } else {
-            long off = getOffset();
+            final long off = getOffset();
             if (off > -1) {
                 buf.append(" at ").append(off);
             }            

module/jsonurl-core/src/main/java/org/jsonurl/ParseException.java

@@ -462,6 +462,7 @@ private static boolean contains(
         // See SuppressWarnings.md#complexity
         "PMD.CyclomaticComplexity",
         "PMD.NPathComplexity",
+        "PMD.CognitiveComplexity",
         "java:S3776"
     })
     private static <T extends Appendable> boolean appendLiteral(

module/jsonurl-core/src/main/java/org/jsonurl/text/JsonUrlTextAppender.java

@@ -55,11 +55,15 @@
  *      <td>{@link java.lang.Double Double}</td></tr>
  * </table>
  */
-final class NumberCoercionMap { //NOPMD - ClassNamingConventions
+final class NumberCoercionMap {
 
     /**
      * Static map of input type to coerced type.
      */
+    // access is guaranteed to be sync inside the static initializer, and it
+    // is read-only thereafter. There's no need for the additional overhead
+    // of ConcurrentHashMap here.
+    @SuppressWarnings("PMD.UseConcurrentHashMap")
     private static final Map<
             Class<? extends Number>,
             Class<? extends Number>> MAP = new HashMap<>();

module/jsonurl-core/src/main/java/org/jsonurl/text/NumberCoercionMap.java

@@ -70,6 +70,7 @@ public static int decode(CharIterator text) throws IOException {
         // See SuppressWarnings.md#complexity
         "PMD.CyclomaticComplexity",
         "PMD.NPathComplexity",
+        "PMD.CognitiveComplexity",
         "java:S3776",
 
         // once you understand UTF-8 it's far more readable with the

module/jsonurl-core/src/main/java/org/jsonurl/util/PercentCodec.java

@@ -44,7 +44,10 @@
  * @author David MacCormack
  * @since 2019-10-01
  */
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
+@SuppressWarnings({
+    "PMD.AvoidDuplicateLiterals",
+    "PMD.ExcessiveClassLength" // yup, I have a lot of tests
+})
 class JsonUrlIteratorTest {
 
     /** empty string. */
@@ -253,7 +256,10 @@ void testAQF(EventTest test) throws IOException {
         testEvents(test, jui);
     }
 
-    @SuppressWarnings("checkstyle:AbbreviationAsWordInName")
+    @SuppressWarnings({
+        "checkstyle:AbbreviationAsWordInName",
+        "PMD.ExcessiveMethodLength" // yup, I have a lot of tests
+    })
     static Stream<EventTest> testAQF() {
         return Stream.concat(COMMON_TESTS.parallelStream(),
             Arrays.stream(new EventTest[] {
@@ -428,7 +434,10 @@ void testNotAQF(EventTest test) throws IOException {
         testEvents(test, jui);
     }
 
-    @SuppressWarnings("checkstyle:AbbreviationAsWordInName")
+    @SuppressWarnings({
+        "checkstyle:AbbreviationAsWordInName",
+        "PMD.ExcessiveMethodLength" // yup, I have a lot of tests
+    })
     static Stream<EventTest> testNotAQF() {
         return Stream.concat(COMMON_TESTS.parallelStream(),
             Arrays.stream(new EventTest[] {

module/jsonurl-core/src/test/java/org/jsonurl/stream/JsonUrlIteratorTest.java

@@ -76,6 +76,7 @@ public static <R> boolean write(
     @SuppressWarnings({
         // See SuppressWarnings.md#complexity
         "PMD.CyclomaticComplexity",
+        "PMD.CognitiveComplexity",
         "PMD.NPathComplexity",
         "java:S3776"
     })
@@ -374,6 +375,7 @@ public static <R> boolean write(
     @SuppressWarnings({
         // See SuppressWarnings.md
         "PMD.CyclomaticComplexity",
+        "PMD.CognitiveComplexity",
         "PMD.AvoidReassigningLoopVariables",
         "java:S127"
     })

module/jsonurl-factory/src/main/java/org/jsonurl/j2se/JsonUrlWriter.java

@@ -121,6 +121,6 @@ void testInline(String text, V obj) throws Exception {
         V obj2 = vfp.parse(jsonUriText);
 
         String jsonText = valueToString(obj2);
-        assertEquals(text, jsonText);
+        assertEquals(text, jsonText, text);
     }
 }