Merge pull request #10 from wadetandy/immutable_errors

Make error validation immutable

Author: richmolj

src/util/validation-errors.ts

@@ -11,24 +11,28 @@ export default class ValidationErrors {
 
   static apply(model: Model, payload: Array<Object>) {
     let instance = new ValidationErrors(model, payload);
-    instance.apply();
+    let errors = instance.apply();
   }
 
   apply() {
+    let errorsAccumulator = {}
+
     this.payload['errors'].forEach((err) => {
       let meta = err['meta'];
       let metaRelationship = meta['relationship'];
 
       if (metaRelationship) {
         this._processRelationship(this.model, metaRelationship);
       } else {
-        this._processResource(this.model, meta);
+        this._processResource(errorsAccumulator, meta);
       }
     });
+
+    this.model.errors = errorsAccumulator
   }
 
-  private _processResource(model: Model, meta: Object) {
-    model.errors[meta['attribute']] = meta['message'];
+  private _processResource(errorsAccumulator: object, meta: Object) {
+    errorsAccumulator[meta['attribute']] = meta['message'];
   }
 
   private _processRelationship(model: Model, meta: Object) {
@@ -38,10 +42,14 @@ export default class ValidationErrors {
         return (r.id === meta['id'] || r.temp_id === meta['temp-id']);
       });
     }
+
     if (meta['relationship']) {
       this._processRelationship(relatedObject, meta['relationship']);
     } else {
-      this._processResource(relatedObject, meta);
+      let relatedAccumulator = {}
+      this._processResource(relatedAccumulator, meta);
+      relatedObject.errors = relatedAccumulator
     }
+
   }
 }

test/integration/validations-test.ts

@@ -110,6 +110,32 @@ describe('validations', function() {
     });
   });
 
+  it('instantiates a new error object instance after save', function(done) {
+    let originalErrors = instance.errors = {foo: 'bar'};
+    let result = instance.save({ with: { books: 'genre' }});
+    let postSavePreValidateErrors = instance.errors;
+
+    expect(postSavePreValidateErrors).not.to.equal(originalErrors);
+
+    result.then(() => {
+      done()
+    }).catch(done)
+  })
+
+  it('instantiates a new error object instance after validate', function(done) {
+    let result = instance.save({ with: { books: 'genre' }});
+
+    let postSavePreValidateErrors = instance.errors;
+
+    result.then((val) => {
+      let postValidateErrors = instance.errors;
+
+      expect(postValidateErrors).not.to.equal(postSavePreValidateErrors);
+
+      done()
+    }).catch(done)
+  })
+
   it('applies errors to nested hasMany relationships', function(done) {
     instance.save({ with: { books: 'genre' }}).then((success) => {
       expect(instance.isPersisted()).to.eq(false);