Merge pull request #19 from stevenharman/fail_loudly_when_casting_non_integer_ids_to_integers

Fail loudly when casting non-Integer ids

Author: richmolj

lib/jsonapi_spec_helpers/helpers.rb

@@ -54,7 +54,7 @@ def json_include(type, index = 0)
 
     def json_ids(integers = false)
       ids = json['data'].map { |d| d['id'] }
-      ids.map!(&:to_i) if integers
+      ids.map! { |id| Integer(id) } if integers
       ids
     end
 

spec/helpers_spec.rb

@@ -150,6 +150,29 @@
         expect(json_ids(true)).to eq([1, 2])
       end
     end
+
+    context 'when ids are non-integers' do
+      let(:index_json) do
+        {
+          'data' => [
+            {
+              'type' => 'posts',
+              'id' => 'ABC123',
+              'attributes' => { }
+            },
+            {
+              'type' => 'posts',
+              'id' => 'KTHXBBQ',
+              'attributes' => { }
+            }
+          ]
+        }
+      end
+
+      it 'fails loudly when trying to cast to integers' do
+        expect{ json_ids(true) }.to raise_error ArgumentError
+      end
+    end
   end
 
   describe '#json_included_types' do