Merge pull request #2 from ProjectVegas/activerecord_independence

Activerecord independence

Author: richmolj

jsonapi_errorable.gemspec

@@ -18,7 +18,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'rails', [">= 4.1", "< 6"]
   spec.add_dependency 'jsonapi-serializable', '~> 0.1'
 
   spec.add_development_dependency "bundler", "~> 1.11"

lib/jsonapi_errorable/serializers/validation.rb

@@ -3,7 +3,7 @@ module Serializers
     class Validation
       attr_reader :object
 
-      def initialize(object, relationship_params, relationship_message = {})
+      def initialize(object, relationship_params = {}, relationship_message = {})
         @object = object
         @relationship_params = relationship_params || {}
         @relationship_message = relationship_message
@@ -33,7 +33,7 @@ def errors
       end
 
       def relationship?(name)
-        return false unless activerecord?
+        return false unless activemodel?
 
         relation_names = object.class.reflect_on_all_associations.map(&:name)
         relation_names.include?(name)
@@ -56,8 +56,8 @@ def pointer_for(object, name)
         end
       end
 
-      def activerecord?
-        object.is_a?(ActiveRecord::Base)
+      def activemodel?
+        object.class.respond_to?(:reflect_on_all_associations)
       end
 
       def relationship_errors(relationship_params)

spec/serializers/serializable_validation_spec.rb

@@ -7,7 +7,7 @@
   let(:instance) { described_class.new(object) }
 
   before do
-    allow(instance).to receive(:activerecord?) { true }
+    allow(instance).to receive(:activemodel?) { true }
     allow(object.class)
       .to receive(:reflect_on_all_associations)
       .and_return([double(name: :pets)])
@@ -18,10 +18,14 @@
     subject { instance.errors }
 
     before do
-      allow(object).to receive(:respond_to?).with(:username) { true }
+      allow(object).to receive(:respond_to?).with(:errors) { true }
     end
 
     context 'when the error is on an attribute' do
+      before do
+        allow(object).to receive(:respond_to?).with(:username) { true }
+      end
+
       it 'renders valid JSONAPI error format' do
         expect(subject).to eq(
           [
@@ -61,7 +65,7 @@
 
       context 'but the object is not activerecord' do
         before do
-          allow(instance).to receive(:activerecord?) { false }
+          allow(instance).to receive(:activemodel?) { false }
           allow(object).to receive(:respond_to?).with(:pets) { true }
         end
 
@@ -146,7 +150,7 @@
 
     context 'when not activerecord' do
       before do
-        allow(instance).to receive(:activerecord?) { false }
+        allow(instance).to receive(:activemodel?) { false }
       end
 
       it { is_expected.to be(false) }