fix specs

Author: Lee Richmond

spec/extra_fields_spec.rb

@@ -42,12 +42,12 @@ def include_foo!
 
   it 'does not include extra fields when not requested' do
     get :index
-    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name last-name))
+    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name last_name))
   end
 
   it 'includes the extra fields in the response when requested' do
     get :index, params: { extra_fields: { authors: 'net_worth' } }
-    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name last-name net-worth))
+    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name last_name net_worth))
   end
 
   it 'alters the scope based on the supplied block' do
@@ -63,7 +63,7 @@ def include_foo!
 
     it 'does not include the extra field in the response' do
       get :index, params: { extra_fields: { authors: 'net_worth' } }
-      expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name last-name))
+      expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name last_name))
     end
   end
 end

spec/fields_spec.rb

@@ -34,17 +34,17 @@ def current_user
 
   it 'limits to only the requested fields' do
     get :index
-    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name last-name uuid))
+    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name last_name uuid))
     get :index, params: { fields: { authors: 'first_name,last_name' } }
-    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name last-name))
+    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name last_name))
   end
 
   it 'disallows fields guarded by :if, even if specified' do
     allow(controller).to receive(:current_user) { 'admin' }
     get :index, params: { fields: { authors: 'first_name,salary' } }
-    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name salary))
+    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name salary))
     allow(controller).to receive(:current_user) { 'non-admin' }
     get :index, params: { fields: { authors: 'first_name,salary' } }
-    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first-name))
+    expect(json_items(0).keys).to match_array(%w(id jsonapi_type first_name))
   end
 end

spec/jsonapi_compliable_spec.rb

@@ -44,7 +44,7 @@ def index
           .once
           .and_call_original
         get :index
-        expect(json_items(0)['first-name']).to eq('Stephen')
+        expect(json_items(0)['first_name']).to eq('Stephen')
       end
     end
 

spec/sorting_spec.rb

@@ -23,7 +23,7 @@ def index
   context 'when passing sort param' do
     subject do
       get :index, params: { sort: sort_param }
-      json_items.map { |n| n['first-name'] }
+      json_items.map { |n| n['first_name'] }
     end
 
     context 'asc' do