fixed findings by julian

gregsdennis · gregsdennis · commit bd653f343a30 · 2022-07-06T23:26:34.000+12:00
diff --git a/README.md b/README.md
@@ -165,7 +165,7 @@ If you suspect one, please [file an issue](https://github.com/json-schema-org/JS
            {
                "description": "Invalid: null",
                "data": {
-                   "type": "null"
+                   "type": null
                },
                "valid": false
            }
diff --git a/tests/draft-next/contains.json b/tests/draft-next/contains.json
@@ -237,5 +237,20 @@
                 "valid": false
             }
         ]
+    },
+    {
+        "description": "contains should properly handle null data",
+        "schema": {
+            "contains": {
+                "type": "null"
+            }
+        },
+        "tests": [
+            {
+                "description": "null items allowed",
+                "data": [ null ],
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft-next/items.json b/tests/draft-next/items.json
@@ -262,7 +262,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft-next/prefixItems.json b/tests/draft-next/prefixItems.json
@@ -89,7 +89,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft-next/properties.json b/tests/draft-next/properties.json
@@ -168,7 +168,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [
diff --git a/tests/draft-next/unevaluatedItems.json b/tests/draft-next/unevaluatedItems.json
@@ -625,5 +625,20 @@
                 "valid": true
             }
         ]
+    },
+    {
+        "description": "unevaluatedItems should properly handle null data",
+        "schema": {
+            "unevaluatedItems": {
+                "type": "null"
+            }
+        },
+        "tests": [
+            {
+                "description": "null items allowed",
+                "data": [ null ],
+                "valid": true
+            }
+        ]
     }
 ]
diff --git a/tests/draft2019-09/additionalItems.json b/tests/draft2019-09/additionalItems.json
@@ -155,7 +155,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2019-09/contains.json b/tests/draft2019-09/contains.json
@@ -156,7 +156,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2019-09/items.json b/tests/draft2019-09/items.json
@@ -273,7 +273,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2019-09/properties.json b/tests/draft2019-09/properties.json
@@ -168,7 +168,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [
diff --git a/tests/draft2019-09/unevaluatedItems.json b/tests/draft2019-09/unevaluatedItems.json
@@ -525,7 +525,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2020-12/contains.json b/tests/draft2020-12/contains.json
@@ -156,7 +156,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2020-12/items.json b/tests/draft2020-12/items.json
@@ -262,7 +262,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2020-12/prefixItems.json b/tests/draft2020-12/prefixItems.json
@@ -89,7 +89,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft2020-12/properties.json b/tests/draft2020-12/properties.json
@@ -168,7 +168,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [
diff --git a/tests/draft2020-12/unevaluatedItems.json b/tests/draft2020-12/unevaluatedItems.json
@@ -635,7 +635,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft3/additionalItems.json b/tests/draft3/additionalItems.json
@@ -119,7 +119,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft3/items.json b/tests/draft3/items.json
@@ -69,7 +69,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft3/properties.json b/tests/draft3/properties.json
@@ -98,7 +98,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [
diff --git a/tests/draft4/additionalItems.json b/tests/draft4/additionalItems.json
@@ -155,7 +155,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft4/items.json b/tests/draft4/items.json
@@ -218,7 +218,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft4/properties.json b/tests/draft4/properties.json
@@ -137,7 +137,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [
diff --git a/tests/draft6/additionalItems.json b/tests/draft6/additionalItems.json
@@ -155,7 +155,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft6/contains.json b/tests/draft6/contains.json
@@ -135,7 +135,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft6/items.json b/tests/draft6/items.json
@@ -273,7 +273,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft6/properties.json b/tests/draft6/properties.json
@@ -168,7 +168,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [
diff --git a/tests/draft7/additionalItems.json b/tests/draft7/additionalItems.json
@@ -155,7 +155,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft7/items.json b/tests/draft7/items.json
@@ -273,7 +273,7 @@
         },
         "tests": [
             {
-                "description": "null properties allowed",
+                "description": "null items allowed",
                 "data": [ null ],
                 "valid": true
             }
diff --git a/tests/draft7/properties.json b/tests/draft7/properties.json
@@ -168,7 +168,7 @@
         "description": "properties should properly handle null data",
         "schema": {
             "properties": {
-                "foo$": {"type": "null"}
+                "foo": {"type": "null"}
             }
         },
         "tests": [

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ If you suspect one, please [file an issue](https://github.com/json-schema-org/JS`
`165`	`165`	`{`
`166`	`166`	`"description": "Invalid: null",`
`167`	`167`	`"data": {`
`168`		`- "type": "null"`
	`168`	`+ "type": null`
`169`	`169`	`},`
`170`	`170`	`"valid": false`
`171`	`171`	`}`
Original file line number	Diff line number	Diff line change
`@@ -237,5 +237,20 @@`
`237`	`237`	`"valid": false`
`238`	`238`	`}`
`239`	`239`	`]`
	`240`	`+ },`
	`241`	`+ {`
	`242`	`+ "description": "contains should properly handle null data",`
	`243`	`+ "schema": {`
	`244`	`+ "contains": {`
	`245`	`+ "type": "null"`
	`246`	`+ }`
	`247`	`+ },`
	`248`	`+ "tests": [`
	`249`	`+ {`
	`250`	`+ "description": "null items allowed",`
	`251`	`+ "data": [ null ],`
	`252`	`+ "valid": true`
	`253`	`+ }`
	`254`	`+ ]`
`240`	`255`	`}`
`241`	`256`	`]`
Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@`
`262`	`262`	`},`
`263`	`263`	`"tests": [`
`264`	`264`	`{`
`265`		`- "description": "null properties allowed",`
	`265`	`+ "description": "null items allowed",`
`266`	`266`	`"data": [ null ],`
`267`	`267`	`"valid": true`
`268`	`268`	`}`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@`
`89`	`89`	`},`
`90`	`90`	`"tests": [`
`91`	`91`	`{`
`92`		`- "description": "null properties allowed",`
	`92`	`+ "description": "null items allowed",`
`93`	`93`	`"data": [ null ],`
`94`	`94`	`"valid": true`
`95`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@`
`168`	`168`	`"description": "properties should properly handle null data",`
`169`	`169`	`"schema": {`
`170`	`170`	`"properties": {`
`171`		`- "foo$": {"type": "null"}`
	`171`	`+ "foo": {"type": "null"}`
`172`	`172`	`}`
`173`	`173`	`},`
`174`	`174`	`"tests": [`
Original file line number	Diff line number	Diff line change
`@@ -625,5 +625,20 @@`
`625`	`625`	`"valid": true`
`626`	`626`	`}`
`627`	`627`	`]`
	`628`	`+ },`
	`629`	`+ {`
	`630`	`+ "description": "unevaluatedItems should properly handle null data",`
	`631`	`+ "schema": {`
	`632`	`+ "unevaluatedItems": {`
	`633`	`+ "type": "null"`
	`634`	`+ }`
	`635`	`+ },`
	`636`	`+ "tests": [`
	`637`	`+ {`
	`638`	`+ "description": "null items allowed",`
	`639`	`+ "data": [ null ],`
	`640`	`+ "valid": true`
	`641`	`+ }`
	`642`	`+ ]`
`628`	`643`	`}`
`629`	`644`	`]`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@`
`155`	`155`	`},`
`156`	`156`	`"tests": [`
`157`	`157`	`{`
`158`		`- "description": "null properties allowed",`
	`158`	`+ "description": "null items allowed",`
`159`	`159`	`"data": [ null ],`
`160`	`160`	`"valid": true`
`161`	`161`	`}`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@`
`156`	`156`	`},`
`157`	`157`	`"tests": [`
`158`	`158`	`{`
`159`		`- "description": "null properties allowed",`
	`159`	`+ "description": "null items allowed",`
`160`	`160`	`"data": [ null ],`
`161`	`161`	`"valid": true`
`162`	`162`	`}`
Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@`
`273`	`273`	`},`
`274`	`274`	`"tests": [`
`275`	`275`	`{`
`276`		`- "description": "null properties allowed",`
	`276`	`+ "description": "null items allowed",`
`277`	`277`	`"data": [ null ],`
`278`	`278`	`"valid": true`
`279`	`279`	`}`