Make sure bignum cases have unique descriptions.

Julian · Julian · commit a5b459fa03ec · 2022-07-31T21:44:52.000+03:00
Fixes a minor inefficiency in draft3 where separate
cases were used instead of just 2 tests.
diff --git a/tests/draft-next/optional/bignum.json b/tests/draft-next/optional/bignum.json
@@ -43,7 +43,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "maximum integer comparison",
         "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
@@ -67,7 +67,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "minimum integer comparison",
         "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {
diff --git a/tests/draft2019-09/optional/bignum.json b/tests/draft2019-09/optional/bignum.json
@@ -43,7 +43,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "maximum integer comparison",
         "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
@@ -67,7 +67,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "minimum integer comparison",
         "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {
diff --git a/tests/draft2020-12/optional/bignum.json b/tests/draft2020-12/optional/bignum.json
@@ -43,7 +43,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "maximum integer comparison",
         "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
@@ -67,7 +67,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "minimum integer comparison",
         "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {
diff --git a/tests/draft3/optional/bignum.json b/tests/draft3/optional/bignum.json
@@ -1,30 +1,13 @@
 [
     {
         "description": "integer",
-        "schema": {"type": "integer"},
+        "schema": { "type": "integer" },
         "tests": [
             {
                 "description": "a bignum is an integer",
                 "data": 12345678910111213141516171819202122232425262728293031,
                 "valid": true
-            }
-        ]
-    },
-    {
-        "description": "number",
-        "schema": {"type": "number"},
-        "tests": [
-            {
-                "description": "a bignum is a number",
-                "data": 98249283749234923498293171823948729348710298301928331,
-                "valid": true
-            }
-        ]
-    },
-    {
-        "description": "integer",
-        "schema": {"type": "integer"},
-        "tests": [
+            },
             {
                 "description": "a negative bignum is an integer",
                 "data": -12345678910111213141516171819202122232425262728293031,
@@ -34,8 +17,13 @@
     },
     {
         "description": "number",
-        "schema": {"type": "number"},
+        "schema": { "type": "number" },
         "tests": [
+            {
+                "description": "a bignum is a number",
+                "data": 98249283749234923498293171823948729348710298301928331,
+                "valid": true
+            },
             {
                 "description": "a negative bignum is a number",
                 "data": -98249283749234923498293171823948729348710298301928331,
@@ -45,7 +33,7 @@
     },
     {
         "description": "string",
-        "schema": {"type": "string"},
+        "schema": { "type": "string" },
         "tests": [
             {
                 "description": "a bignum is not a string",
@@ -55,8 +43,8 @@
         ]
     },
     {
-        "description": "integer comparison",
-        "schema": {"maximum": 18446744073709551615},
+        "description": "maximum integer comparison",
+        "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
                 "description": "comparison works for high numbers",
@@ -80,8 +68,8 @@
         ]
     },
     {
-        "description": "integer comparison",
-        "schema": {"minimum": -18446744073709551615},
+        "description": "minimum integer comparison",
+        "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {
                 "description": "comparison works for very negative numbers",
diff --git a/tests/draft4/optional/bignum.json b/tests/draft4/optional/bignum.json
@@ -43,7 +43,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "maximum integer comparison",
         "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
@@ -68,7 +68,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "minimum integer comparison",
         "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {
diff --git a/tests/draft6/optional/bignum.json b/tests/draft6/optional/bignum.json
@@ -43,7 +43,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "maximum integer comparison",
         "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
@@ -67,7 +67,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "minimum integer comparison",
         "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {
diff --git a/tests/draft7/optional/bignum.json b/tests/draft7/optional/bignum.json
@@ -43,7 +43,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "maximum integer comparison",
         "schema": { "maximum": 18446744073709551615 },
         "tests": [
             {
@@ -67,7 +67,7 @@
         ]
     },
     {
-        "description": "integer comparison",
+        "description": "minimum integer comparison",
         "schema": { "minimum": -18446744073709551615 },
         "tests": [
             {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@`
`43`	`43`	`]`
`44`	`44`	`},`
`45`	`45`	`{`
`46`		`- "description": "integer comparison",`
	`46`	`+ "description": "maximum integer comparison",`
`47`	`47`	`"schema": { "maximum": 18446744073709551615 },`
`48`	`48`	`"tests": [`
`49`	`49`	`{`
`@@ -67,7 +67,7 @@`
`67`	`67`	`]`
`68`	`68`	`},`
`69`	`69`	`{`
`70`		`- "description": "integer comparison",`
	`70`	`+ "description": "minimum integer comparison",`
`71`	`71`	`"schema": { "minimum": -18446744073709551615 },`
`72`	`72`	`"tests": [`
`73`	`73`	`{`