Merge pull request #218 from stramel/feature/arrayClearPerf

Dervisevic · Dervisevic · commit 76a6509a271a · 2015-01-16T08:54:23.000+01:00
refactor(array): change `shift` to `pop` for performance
diff --git a/src/directives/array.js b/src/directives/array.js
@@ -170,7 +170,7 @@ angular.module('schemaForm').directive('sfArray', ['sfSelect', 'schemaForm', 'sf
                 // Apparently the fastest way to clear an array, readable too.
                 // http://jsperf.com/array-destroy/32
                 while (arr.length > 0) {
-                  arr.shift();
+                  arr.pop();
                 }
 
                 form.titleMap.forEach(function(item, index) {

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ angular.module('schemaForm').directive('sfArray', ['sfSelect', 'schemaForm', 'sf`
`170`	`170`	`// Apparently the fastest way to clear an array, readable too.`
`171`	`171`	`// http://jsperf.com/array-destroy/32`
`172`	`172`	`while (arr.length > 0) {`
`173`		`- arr.shift();`
	`173`	`+ arr.pop();`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`form.titleMap.forEach(function(item, index) {`