Merge pull request #11 from TotalTechGeek/tests/add-tests-for-#10

Contribute tests for PR #10

Author: TotalTechGeek

async.test.js

@@ -657,6 +657,78 @@ modes.forEach((logic) => {
       expect(answer2).toStrictEqual([])
     })
 
+    test('length string', async () => {
+      const answer = await logic.run({
+        length: 'hello'
+      })
+
+      expect(answer).toStrictEqual(5)
+    })
+
+    test('length array', async () => {
+      const answer = await logic.run({
+        length: ['hello']
+      })
+
+      expect(answer).toStrictEqual(1)
+    })
+
+    test('length object (2 keys)', async () => {
+      const answer = await logic.run({
+        length: { preserve: { a: 1, b: 2 } }
+      })
+
+      expect(answer).toStrictEqual(2)
+    })
+
+    test('length object (1 keys)', async () => {
+      const answer = await logic.run({
+        length: { preserve: { a: 1 } }
+      })
+
+      expect(answer).toStrictEqual(1)
+    })
+
+    test('get from array', async () => {
+      const answer = await logic.run({
+        get: [['hi'], 'length']
+      })
+
+      expect(answer).toStrictEqual(1)
+    })
+
+    test('get from object', async () => {
+      const answer = await logic.run({
+        get: [{ preserve: { a: 1 } }, 'a']
+      })
+
+      expect(answer).toStrictEqual(1)
+    })
+
+    test('get from object default', async () => {
+      const answer = await logic.run({
+        get: [{ preserve: {} }, 'a', 5]
+      })
+
+      expect(answer).toStrictEqual(5)
+    })
+
+    test('length object (0 keys)', async () => {
+      const answer = await logic.run({
+        length: { preserve: {} }
+      })
+
+      expect(answer).toStrictEqual(0)
+    })
+
+    test('length object (null)', async () => {
+      const answer = await logic.run({
+        length: { preserve: null }
+      })
+
+      expect(answer).toStrictEqual(0)
+    })
+
     test('merge', async () => {
       const answer = await logic.run({
         merge: [{ preserve: ['b'] }, { preserve: ['c'] }]

defaultMethods.js

@@ -154,14 +154,8 @@ const defaultMethods = {
     return string.substr(from, end)
   },
   length: (i) => {
-    if ((typeof i === 'string' || Array.isArray(i))) {
-      return i.length
-    }
-
-    if (i && typeof i === 'object') {
-      return Object.keys(i).length
-    }
-
+    if (typeof i === 'string' || Array.isArray(i)) return i.length
+    if (i && typeof i === 'object') return Object.keys(i).length
     return 0
   },
   get: {

test.js

@@ -708,6 +708,38 @@ modes.forEach((logic) => {
       expect(answer).toStrictEqual(1)
     })
 
+    test('length object (2 keys)', () => {
+      const answer = logic.run({
+        length: { preserve: { a: 1, b: 2 } }
+      })
+
+      expect(answer).toStrictEqual(2)
+    })
+
+    test('length object (1 keys)', () => {
+      const answer = logic.run({
+        length: { preserve: { a: 1 } }
+      })
+
+      expect(answer).toStrictEqual(1)
+    })
+
+    test('length object (0 keys)', () => {
+      const answer = logic.run({
+        length: { preserve: {} }
+      })
+
+      expect(answer).toStrictEqual(0)
+    })
+
+    test('length object (null)', () => {
+      const answer = logic.run({
+        length: { preserve: null }
+      })
+
+      expect(answer).toStrictEqual(0)
+    })
+
     test('get from array', () => {
       const answer = logic.run({
         get: [['hi'], 'length']