Added name validation in meta (#67)

Author: vtsykun

src/Document/Meta.php

@@ -9,6 +9,8 @@ class Meta implements \JsonSerializable
 
     public function __construct(\stdClass $data)
     {
+        $this->validateObject($data);
+
         $this->data = $data;
     }
 
@@ -21,4 +23,22 @@ public function jsonSerialize()
     {
         return $this->data;
     }
+
+    private function validateObject($object)
+    {
+        foreach ($object as $name => $value) {
+            if (is_string($name) && !$this->isValidMemberName($name)) {
+                throw new \OutOfBoundsException("Not a valid attribute name '$name'");
+            }
+
+            if (is_array($value) || $value instanceof \stdClass) {
+                $this->validateObject($value);
+            }
+        }
+    }
+
+    private function isValidMemberName(string $name): bool
+    {
+        return preg_match('/^(?=[^-_ ])[a-zA-Z0-9\x{0080}-\x{FFFF}-_ ]*(?<=[^-_ ])$/u', $name) === 1;
+    }
 }

test/MemberNamesTest.php

@@ -4,6 +4,7 @@
 namespace JsonApiPhp\JsonApi\Test;
 
 use JsonApiPhp\JsonApi\Document\Link\Link;
+use JsonApiPhp\JsonApi\Document\Meta;
 use JsonApiPhp\JsonApi\Document\Resource\Relationship;
 use JsonApiPhp\JsonApi\Document\Resource\ResourceObject;
 use PHPUnit\Framework\TestCase;
@@ -45,6 +46,48 @@ public function testInvalidRelationshipNamesAreNotAllowed(string $name)
         $res->setRelationship($name, Relationship::fromSelfLink(new Link('https://example.com')));
     }
 
+    /**
+     * @param string $name
+     * @expectedException \OutOfBoundsException
+     * @expectedExceptionMessage Not a valid attribute name
+     * @dataProvider             invalidAttributeNames
+     */
+    public function testInvalidMetaNames(string $name)
+    {
+        Meta::fromArray(
+            [
+                'copyright' => 'Copyright 2015 Example Corp.',
+                'authors' => [
+                    [
+                        'firstname' => 'Yehuda',
+                        $name => 'Katz',
+                    ],
+                ],
+            ]
+        );
+    }
+
+    /**
+     * @param string $name
+     * @dataProvider             validAttributeNames
+     */
+    public function testValidMetaNames(string $name)
+    {
+        $meta = Meta::fromArray(
+            [
+                'copyright' => 'Copyright 2015 Example Corp.',
+                'authors' => [
+                    [
+                        'firstname' => 'Yehuda',
+                        $name => 'Katz',
+                    ],
+                ],
+            ]
+        );
+
+        $this->assertInternalType('string', json_encode($meta));
+    }
+
     /**
      * @param string $name
      * @dataProvider             validAttributeNames