Fail at startup when resource implements IVersionedIdentifiable without IVersionedIdentifiable<TId, TVersion>

Author: Bart Koelman

src/JsonApiDotNetCore/Configuration/ResourceGraphBuilder.cs

@@ -127,6 +127,13 @@ public ResourceGraphBuilder Add(Type resourceClrType, Type? idClrType = null, st
                 return this;
             }
 
+            if (resourceClrType.IsOrImplementsInterface<IVersionedIdentifiable>() &&
+                !resourceClrType.IsOrImplementsInterface(typeof(IVersionedIdentifiable<,>)))
+            {
+                throw new InvalidConfigurationException(
+                    $"Resource type '{resourceClrType}' implements 'IVersionedIdentifiable', but not 'IVersionedIdentifiable<TId, TVersion>'.");
+            }
+
             if (resourceClrType.IsOrImplementsInterface<IIdentifiable>())
             {
                 string effectivePublicName = publicName ?? FormatResourceName(resourceClrType);

test/JsonApiDotNetCoreTests/UnitTests/ResourceGraph/ResourceGraphBuilderTests.cs

@@ -167,6 +167,21 @@ public void Cannot_add_resource_that_implements_only_non_generic_IIdentifiable()
                 .WithMessage($"Resource type '{typeof(ResourceWithoutId)}' implements 'IIdentifiable', but not 'IIdentifiable<TId>'.");
         }
 
+        [Fact]
+        public void Cannot_add_versioned_resource_that_implements_only_non_generic_IVersionedIdentifiable()
+        {
+            // Arrange
+            var options = new JsonApiOptions();
+            var builder = new ResourceGraphBuilder(options, NullLoggerFactory.Instance);
+
+            // Act
+            Action action = () => builder.Add(typeof(VersionedResourceWithoutToken));
+
+            // Assert
+            action.Should().ThrowExactly<InvalidConfigurationException>().WithMessage(
+                $"Resource type '{typeof(VersionedResourceWithoutToken)}' implements 'IVersionedIdentifiable', but not 'IVersionedIdentifiable<TId, TVersion>'.");
+        }
+
         [Fact]
         public void Cannot_build_graph_with_missing_related_HasOne_resource()
         {
@@ -341,6 +356,13 @@ private sealed class ResourceWithoutId : IIdentifiable
             public string? LocalId { get; set; }
         }
 
+        private sealed class VersionedResourceWithoutToken : IVersionedIdentifiable
+        {
+            public string? StringId { get; set; }
+            public string? LocalId { get; set; }
+            public string? Version { get; set; }
+        }
+
         [UsedImplicitly(ImplicitUseKindFlags.InstantiatedNoFixedConstructorSignature)]
         private sealed class NonResource
         {