tests: implicit remove through create tests

Author: maurei

src/JsonApiDotNetCore/Data/DefaultEntityRepository.cs

@@ -195,9 +195,10 @@ private void LoadInverseRelationships(object trackedRelationshipValue, Relations
             }
         }
 
-        private bool IsHasOneRelationship(string inverseNavigation, Type type)
+
+        private bool IsHasOneRelationship(string internalRelationshipName, Type type)
         {
-            var relationshipAttr = _jsonApiContext.ResourceGraph.GetContextEntity(type).Relationships.Single(r => r.InternalRelationshipName == inverseNavigation);
+            var relationshipAttr = _jsonApiContext.ResourceGraph.GetContextEntity(type).Relationships.Single(r => r.InternalRelationshipName == internalRelationshipName);
             if (relationshipAttr is HasOneAttribute) return true;
             return false;
         }
@@ -455,7 +456,7 @@ protected void LoadCurrentRelationships(TEntity oldEntity, RelationshipAttribute
         /// retrieve from the context WHICH relationships to update, but the actual
         /// values should not come from the context.
         /// </summary>
-        protected void AssignRelationshipValue(TEntity oldEntity, object relationshipValue, RelationshipAttribute relationshipAttribute)
+        private void AssignRelationshipValue(TEntity oldEntity, object relationshipValue, RelationshipAttribute relationshipAttribute)
         {
             if (relationshipAttribute is HasManyThroughAttribute throughAttribute)
             {
@@ -493,7 +494,7 @@ private void AssignHasManyThrough(TEntity entity, HasManyThroughAttribute hasMan
         /// A helper method that gets the relationship value in the case of 
         /// entity resource separation.
         /// </summary>
-        IIdentifiable GetEntityResourceSeparationValue(TEntity entity, HasOneAttribute attribute)
+        private IIdentifiable GetEntityResourceSeparationValue(TEntity entity, HasOneAttribute attribute)
         {
             if (attribute.EntityPropertyName == null)
             {
@@ -506,7 +507,7 @@ IIdentifiable GetEntityResourceSeparationValue(TEntity entity, HasOneAttribute a
         /// A helper method that gets the relationship value in the case of 
         /// entity resource separation.
         /// </summary>
-        IEnumerable<IIdentifiable> GetEntityResourceSeparationValue(TEntity entity, HasManyAttribute attribute)
+        private IEnumerable<IIdentifiable> GetEntityResourceSeparationValue(TEntity entity, HasManyAttribute attribute)
         {
             if (attribute.EntityPropertyName == null)
             {
@@ -522,7 +523,7 @@ IEnumerable<IIdentifiable> GetEntityResourceSeparationValue(TEntity entity, HasM
         /// 
         /// useful article: https://stackoverflow.com/questions/30987806/dbset-attachentity-vs-dbcontext-entryentity-state-entitystate-modified
         /// </summary>
-        IIdentifiable AttachOrGetTracked(IIdentifiable relationshipValue)
+        private IIdentifiable AttachOrGetTracked(IIdentifiable relationshipValue)
         {
             var trackedEntity = _context.GetTrackedEntity(relationshipValue);
 

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/CreatingDataTests.cs

@@ -17,6 +17,7 @@
 using Microsoft.EntityFrameworkCore;
 using Newtonsoft.Json;
 using Xunit;
+using Person = JsonApiDotNetCoreExample.Models.Person;
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec
 {
@@ -26,6 +27,7 @@ public class CreatingDataTests
         private TestFixture<TestStartup> _fixture;
         private IJsonApiContext _jsonApiContext;
         private Faker<TodoItem> _todoItemFaker;
+        private Faker<Person> _personFaker;
 
         public CreatingDataTests(TestFixture<TestStartup> fixture)
         {
@@ -35,6 +37,10 @@ public CreatingDataTests(TestFixture<TestStartup> fixture)
                 .RuleFor(t => t.Description, f => f.Lorem.Sentence())
                 .RuleFor(t => t.Ordinal, f => f.Random.Number())
                 .RuleFor(t => t.CreatedDate, f => f.Date.Past());
+            _personFaker = new Faker<Person>()
+                    .RuleFor(t => t.FirstName, f => f.Name.FirstName())
+                    .RuleFor(t => t.LastName, f => f.Name.LastName());
+
         }
 
         [Fact]
@@ -586,5 +592,113 @@ public async Task Respond_409_ToIncorrectEntityType()
             // assert
             Assert.Equal(HttpStatusCode.Conflict, response.StatusCode);
         }
+
+        [Fact]
+        public async Task Create_With_ToOne_Relationship_With_Implicit_Remove()
+        {
+            // Arrange
+            var context = _fixture.GetService<AppDbContext>();
+            var passport = new Passport();
+            var person1 = _personFaker.Generate();
+            person1.Passport = passport;
+            context.People.AddRange(new List<Person>() { person1 });
+            await context.SaveChangesAsync();
+            var passportId = person1.PassportId;
+            var content = new
+            {
+                data = new
+                {
+                    type = "people",
+                    attributes = new Dictionary<string, string>() { { "first-name", "Joe" } },
+                    relationships = new Dictionary<string, object>
+                    {
+                        { "passport", new
+                            {
+                                data = new { type = "passports", id = $"{passportId}" }
+                            }
+                        }
+                    }
+                }
+            };
+
+            var httpMethod = new HttpMethod("POST");
+            var route = $"/api/v1/people";
+            var request = new HttpRequestMessage(httpMethod, route);
+
+            string serializedContent = JsonConvert.SerializeObject(content);
+            request.Content = new StringContent(serializedContent);
+            request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/vnd.api+json");
+
+            // Act
+            var response = await _fixture.Client.SendAsync(request);
+            var body = await response.Content.ReadAsStringAsync();
+            var personResult = _fixture.GetService<IJsonApiDeSerializer>().Deserialize<Person>(body);
+
+            // Assert
+
+            Assert.True(HttpStatusCode.Created == response.StatusCode, $"{route} returned {response.StatusCode} status code with payload: {body}");
+            var dbPerson = context.People.AsNoTracking().Where(p => p.Id == personResult.Id).Include("Passport").FirstOrDefault();
+            Assert.Equal(passportId, dbPerson.Passport.Id);
+        }
+
+        [Fact]
+        public async Task Create_With_ToMany_Relationship_With_Implicit_Remove()
+        {
+            // Arrange
+            var context = _fixture.GetService<AppDbContext>();
+            var person1 = _personFaker.Generate();
+            person1.TodoItems = _todoItemFaker.Generate(3).ToList();
+            context.People.AddRange(new List<Person>() { person1 });
+            await context.SaveChangesAsync();
+            var todoItem1Id = person1.TodoItems[0].Id;
+            var todoItem2Id = person1.TodoItems[1].Id;
+
+            var content = new
+            {
+                data = new
+                {
+                    type = "people",
+                    attributes = new Dictionary<string, string>() { { "first-name", "Joe" } },
+                    relationships = new Dictionary<string, object>
+                    {
+                        { "todo-items", new
+                            {
+                                data = new List<object>
+                                {
+                                    new {
+                                        type = "todo-items",
+                                        id = $"{todoItem1Id}"
+                                    },
+                                    new {
+                                        type = "todo-items",
+                                        id = $"{todoItem2Id}"
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            };
+
+            var httpMethod = new HttpMethod("POST");
+            var route = $"/api/v1/people";
+            var request = new HttpRequestMessage(httpMethod, route);
+
+            string serializedContent = JsonConvert.SerializeObject(content);
+            request.Content = new StringContent(serializedContent);
+            request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/vnd.api+json");
+
+            // Act
+            var response = await _fixture.Client.SendAsync(request);
+            var body = await response.Content.ReadAsStringAsync();
+            var personResult = _fixture.GetService<IJsonApiDeSerializer>().Deserialize<Person>(body);
+
+            // Assert
+            Assert.True(HttpStatusCode.Created == response.StatusCode, $"{route} returned {response.StatusCode} status code with payload: {body}");
+            var dbPerson = context.People.AsNoTracking().Where(p => p.Id == personResult.Id).Include("TodoItems").FirstOrDefault();
+            Assert.Equal(2, dbPerson.TodoItems.Count);
+            Assert.NotNull(dbPerson.TodoItems.SingleOrDefault(ti => ti.Id == todoItem1Id));
+            Assert.NotNull(dbPerson.TodoItems.SingleOrDefault(ti => ti.Id == todoItem2Id));
+        }
     }
 }