Skip to content

Commit ee93822

Browse files
bkoelmanbkoelman
committed
Fix CA2000: Dispose objects before losing scope
1 parent 2f54984 commit ee93822

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+259
-43
lines changed

‎test/OpenApiKiotaEndToEndTests/AtomicOperations/AtomicCreateResourceTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
namespace OpenApiKiotaEndToEndTests.AtomicOperations;
1414

15-
public sealed class AtomicCreateResourceTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>
15+
public sealed class AtomicCreateResourceTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>, IDisposable
1616
{
1717
private readonly IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext> _testContext;
1818
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -209,4 +209,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
209209
courseInDatabase.Description.Should().BeNull();
210210
});
211211
}
212+
213+
public void Dispose()
214+
{
215+
_requestAdapterFactory.Dispose();
216+
}
212217
}

‎test/OpenApiKiotaEndToEndTests/AtomicOperations/AtomicDeleteResourceTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
namespace OpenApiKiotaEndToEndTests.AtomicOperations;
1313

14-
public sealed class AtomicDeleteResourceTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>
14+
public sealed class AtomicDeleteResourceTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>, IDisposable
1515
{
1616
private readonly IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext> _testContext;
1717
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -76,4 +76,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
7676
enrollmentInDatabase.Should().BeNull();
7777
});
7878
}
79+
80+
public void Dispose()
81+
{
82+
_requestAdapterFactory.Dispose();
83+
}
7984
}

‎test/OpenApiKiotaEndToEndTests/AtomicOperations/AtomicLocalIdTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
namespace OpenApiKiotaEndToEndTests.AtomicOperations;
1515

16-
public sealed class AtomicLocalIdTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>
16+
public sealed class AtomicLocalIdTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>, IDisposable
1717
{
1818
private readonly IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext> _testContext;
1919
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -234,4 +234,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
234234
enrollmentInDatabase.Student.Id.Should().Be(newStudentId);
235235
});
236236
}
237+
238+
public void Dispose()
239+
{
240+
_requestAdapterFactory.Dispose();
241+
}
237242
}

‎test/OpenApiKiotaEndToEndTests/AtomicOperations/AtomicRelationshipTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
namespace OpenApiKiotaEndToEndTests.AtomicOperations;
1414

15-
public sealed class AtomicRelationshipTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>
15+
public sealed class AtomicRelationshipTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>, IDisposable
1616
{
1717
private readonly IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext> _testContext;
1818
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -276,4 +276,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
276276
teacherInDatabase.Teaches.ElementAt(0).Id.Should().Be(existingTeacher.Teaches.ElementAt(1).Id);
277277
});
278278
}
279+
280+
public void Dispose()
281+
{
282+
_requestAdapterFactory.Dispose();
283+
}
279284
}

‎test/OpenApiKiotaEndToEndTests/AtomicOperations/AtomicUpdateResourceTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
namespace OpenApiKiotaEndToEndTests.AtomicOperations;
1616

17-
public sealed class AtomicUpdateResourceTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>
17+
public sealed class AtomicUpdateResourceTests : IClassFixture<IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext>>, IDisposable
1818
{
1919
private readonly IntegrationTestContext<OpenApiStartup<OperationsDbContext>, OperationsDbContext> _testContext;
2020
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -261,4 +261,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
261261
enrollmentInDatabase.Course.Id.Should().Be(existingCourse.Id);
262262
});
263263
}
264+
265+
public void Dispose()
266+
{
267+
_requestAdapterFactory.Dispose();
268+
}
264269
}

‎test/OpenApiKiotaEndToEndTests/ClientIdGenerationModes/ClientIdGenerationModesTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace OpenApiKiotaEndToEndTests.ClientIdGenerationModes;
1313

1414
public sealed class ClientIdGenerationModesTests
15-
: IClassFixture<IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext>>
15+
: IClassFixture<IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext>>, IDisposable
1616
{
1717
private readonly IntegrationTestContext<OpenApiStartup<ClientIdGenerationDbContext>, ClientIdGenerationDbContext> _testContext;
1818
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -265,4 +265,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
265265
playerGroupInDatabase.Name.Should().Be(newPlayerGroup.Name);
266266
});
267267
}
268+
269+
public void Dispose()
270+
{
271+
_requestAdapterFactory.Dispose();
272+
}
268273
}

‎test/OpenApiKiotaEndToEndTests/Headers/ETagTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
namespace OpenApiKiotaEndToEndTests.Headers;
1616

17-
public sealed class ETagTests : IClassFixture<IntegrationTestContext<OpenApiStartup<HeaderDbContext>, HeaderDbContext>>
17+
public sealed class ETagTests : IClassFixture<IntegrationTestContext<OpenApiStartup<HeaderDbContext>, HeaderDbContext>>, IDisposable
1818
{
1919
private readonly IntegrationTestContext<OpenApiStartup<HeaderDbContext>, HeaderDbContext> _testContext;
2020
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -236,4 +236,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
236236
eTagHeaderValues.ShouldHaveCount(1);
237237
eTagHeaderValues[0].Should().Match("\"*\"");
238238
}
239+
240+
public void Dispose()
241+
{
242+
_requestAdapterFactory.Dispose();
243+
}
239244
}

‎test/OpenApiKiotaEndToEndTests/Headers/HeaderTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
namespace OpenApiKiotaEndToEndTests.Headers;
1414

15-
public sealed class HeaderTests : IClassFixture<IntegrationTestContext<OpenApiStartup<HeaderDbContext>, HeaderDbContext>>
15+
public sealed class HeaderTests : IClassFixture<IntegrationTestContext<OpenApiStartup<HeaderDbContext>, HeaderDbContext>>, IDisposable
1616
{
1717
private readonly IntegrationTestContext<OpenApiStartup<HeaderDbContext>, HeaderDbContext> _testContext;
1818
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -184,4 +184,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
184184
contentLengthHeaderValues.ShouldHaveCount(1);
185185
long.Parse(contentLengthHeaderValues[0]).Should().BeGreaterThan(0);
186186
}
187+
188+
public void Dispose()
189+
{
190+
_requestAdapterFactory.Dispose();
191+
}
187192
}

‎test/OpenApiKiotaEndToEndTests/Links/AlternateOpenApiRouteTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
namespace OpenApiKiotaEndToEndTests.Links;
1414

15-
public sealed class AlternateOpenApiRouteTests : IClassFixture<IntegrationTestContext<OpenApiStartup<LinkDbContext>, LinkDbContext>>
15+
public sealed class AlternateOpenApiRouteTests : IClassFixture<IntegrationTestContext<OpenApiStartup<LinkDbContext>, LinkDbContext>>, IDisposable
1616
{
1717
private readonly IntegrationTestContext<OpenApiStartup<LinkDbContext>, LinkDbContext> _testContext;
1818
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -52,4 +52,9 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
5252
response.Links.ShouldNotBeNull();
5353
response.Links.Describedby.Should().Be("/api-docs/v1/swagger.yaml");
5454
}
55+
56+
public void Dispose()
57+
{
58+
_requestAdapterFactory.Dispose();
59+
}
5560
}

‎test/OpenApiKiotaEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
namespace OpenApiKiotaEndToEndTests.ModelStateValidation;
1414

1515
public sealed class ModelStateValidationTests
16-
: IClassFixture<IntegrationTestContext<OpenApiStartup<ModelStateValidationDbContext>, ModelStateValidationDbContext>>
16+
: IClassFixture<IntegrationTestContext<OpenApiStartup<ModelStateValidationDbContext>, ModelStateValidationDbContext>>, IDisposable
1717
{
1818
private readonly IntegrationTestContext<OpenApiStartup<ModelStateValidationDbContext>, ModelStateValidationDbContext> _testContext;
1919
private readonly TestableHttpClientRequestAdapterFactory _requestAdapterFactory;
@@ -594,4 +594,9 @@ public async Task Can_create_resource_with_valid_properties()
594594
// Assert
595595
await action.Should().NotThrowAsync();
596596
}
597+
598+
public void Dispose()
599+
{
600+
_requestAdapterFactory.Dispose();
601+
}
597602
}

0 commit comments

Comments
 (0)